New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nls readme.md update #8438

Merged
merged 7 commits into from Aug 4, 2014

Conversation

Projects
None yet
3 participants
@tan9
Contributor

tan9 commented Jul 17, 2014

No description provided.

@sbruchmann

This comment has been minimized.

Show comment
Hide comment
@sbruchmann

sbruchmann Jul 17, 2014

Small typo at commot_SHA_of_root_index.html.

sbruchmann commented on src/nls/README.md in d050f9a Jul 17, 2014

Small typo at commot_SHA_of_root_index.html.

@sbruchmann

This comment has been minimized.

Show comment
Hide comment
@sbruchmann

sbruchmann Jul 17, 2014

Same typo as above.

sbruchmann commented on src/nls/README.md in d050f9a Jul 17, 2014

Same typo as above.

@sbruchmann

This comment has been minimized.

Show comment
Hide comment
@sbruchmann

sbruchmann Jul 17, 2014

Typo at commot_SHA_of_root_strings.js.

sbruchmann commented on src/nls/README.md in a2938c6 Jul 17, 2014

Typo at commot_SHA_of_root_strings.js.

@tan9

This comment has been minimized.

Show comment
Hide comment
@tan9

tan9 Jul 17, 2014

Contributor

@sbruchmann , Thanks for pointing it out. Typo fixed.

Contributor

tan9 commented Jul 17, 2014

@sbruchmann , Thanks for pointing it out. Typo fixed.

@sbruchmann

This comment has been minimized.

Show comment
Hide comment
@sbruchmann

sbruchmann Jul 17, 2014

Typo at characters only, as descirbed.

sbruchmann commented on src/nls/README.md in 26ee520 Jul 17, 2014

Typo at characters only, as descirbed.

@tan9

This comment has been minimized.

Show comment
Hide comment
@tan9

tan9 Jul 17, 2014

Contributor

Typo fixed.

I think I have to go to sleep now, it is 2:00AM here~

Contributor

tan9 commented Jul 17, 2014

Typo fixed.

I think I have to go to sleep now, it is 2:00AM here~

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Jul 18, 2014

Contributor

Triage complete.

@tan9 Thanks for the cleaning this up. I notice that there are several places in this file that describe inserting/updating SHA comment at end of strings.js file. I think it would simplify this file if a section were added with this info, and then references to the "sha" section added in all of the other places. Do you care to make that change?

Contributor

redmunds commented Jul 18, 2014

Triage complete.

@tan9 Thanks for the cleaning this up. I notice that there are several places in this file that describe inserting/updating SHA comment at end of strings.js file. I think it would simplify this file if a section were added with this info, and then references to the "sha" section added in all of the other places. Do you care to make that change?

@redmunds redmunds self-assigned this Jul 18, 2014

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Aug 4, 2014

Contributor

Thanks. Merging.

Contributor

redmunds commented Aug 4, 2014

Thanks. Merging.

redmunds added a commit that referenced this pull request Aug 4, 2014

@redmunds redmunds merged commit 78cad76 into adobe:master Aug 4, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment