New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize existing indentation when indenting close braces #8439

Merged
merged 5 commits into from Jul 22, 2014

Conversation

Projects
None yet
4 participants
@mackenza
Contributor

mackenza commented Jul 17, 2014

this PR addresses #8395 and is a 2nd attempt. I refactored my fix based on feedback from @peterflynn and @redmunds in #8426

@peterflynn

View changes

Show outdated Hide outdated src/editor/Editor.js Outdated

@dangoor dangoor changed the title from fix for #8395 to Recognize existing indentation when autoclosing braces Jul 21, 2014

@dangoor dangoor changed the title from Recognize existing indentation when autoclosing braces to Recognize existing indentation when indenting close braces Jul 21, 2014

@dangoor

This comment has been minimized.

Show comment
Hide comment
@dangoor

dangoor Jul 21, 2014

Contributor

Updated the title to be more descriptive. Feel free to change if I didn't capture the intent here well enough! Thanks for the PR

Contributor

dangoor commented Jul 21, 2014

Updated the title to be more descriptive. Feel free to change if I didn't capture the intent here well enough! Thanks for the PR

@redmunds redmunds self-assigned this Jul 22, 2014

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Jul 22, 2014

Contributor

Looks good. Merging.

Contributor

redmunds commented Jul 22, 2014

Looks good. Merging.

redmunds added a commit that referenced this pull request Jul 22, 2014

Merge pull request #8439 from mackenza/issue-8395
Recognize existing indentation when indenting close braces

@redmunds redmunds merged commit ae17456 into adobe:master Jul 22, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment