Clear up bug #6722 (Linux: menu items cut/copy/paste not working) #8497

Merged
merged 1 commit into from Aug 4, 2014

Conversation

Projects
None yet
5 participants
@peterflynn
Member

peterflynn commented Jul 22, 2014

To avoid confusion, don't show Cut/Copy/Paste in HTML menus. They'll only work in the native shell, with specially bound native menu items.

Whenever Linux native menu support lands, these menu items will automatically be exposed, and they should work at that point. In "in-browser" mode, the menu items will forever stay hidden, since there's simply no way to make them work there.

Fix/mitigate bug #6722 (Linux: menu items cut/copy/paste not working)…
… - To

avoid confusion, don't show Cut/Copy/Paste in HTML menu. They'll only work
in the native shell, with specially bound native menu items.
@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jul 22, 2014

Contributor

Well, it must be possible to get them working in-browser, as they do work in the CM demo as well...

Contributor

MarcelGerber commented Jul 22, 2014

Well, it must be possible to get them working in-browser, as they do work in the CM demo as well...

@TomMalbran

This comment has been minimized.

Show comment
Hide comment
@TomMalbran

TomMalbran Jul 22, 2014

Contributor

@saplayer What do you mean with it is working with the CM demo?

Contributor

TomMalbran commented Jul 22, 2014

@saplayer What do you mean with it is working with the CM demo?

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jul 22, 2014

Contributor

Well, in the CodeMirror demo (http://codemirror.net), you can copy, cut and paste whatever you want.
We should be able to do that as well, I guess.

But of course we don't have an official in-browser approach yet, so we don't need to worry our brains.

Contributor

MarcelGerber commented Jul 22, 2014

Well, in the CodeMirror demo (http://codemirror.net), you can copy, cut and paste whatever you want.
We should be able to do that as well, I guess.

But of course we don't have an official in-browser approach yet, so we don't need to worry our brains.

@TomMalbran

This comment has been minimized.

Show comment
Hide comment
@TomMalbran

TomMalbran Jul 22, 2014

Contributor

But that is because the Browser is adding those menus automatically, and not CodeMirror. We can't do that with the html menus.

Contributor

TomMalbran commented Jul 22, 2014

But that is because the Browser is adding those menus automatically, and not CodeMirror. We can't do that with the html menus.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jul 22, 2014

Contributor

Oh well, I thought about Ctrl-C, Ctrl-X and Ctrl-V the whole time, sorry.
Everything's fine.

Contributor

MarcelGerber commented Jul 22, 2014

Oh well, I thought about Ctrl-C, Ctrl-X and Ctrl-V the whole time, sorry.
Everything's fine.

@TomMalbran

This comment has been minimized.

Show comment
Hide comment
@TomMalbran

TomMalbran Jul 22, 2014

Contributor

The shortcuts still work fine. The menus are the issue since you can't execute Cut/Copy/Paste from JS.

Contributor

TomMalbran commented Jul 22, 2014

The shortcuts still work fine. The menus are the issue since you can't execute Cut/Copy/Paste from JS.

@peterflynn

This comment has been minimized.

Show comment
Hide comment
@peterflynn

peterflynn Jul 22, 2014

Member

Yep -- in-browser, you can have the default native menu with working cut/copy/paste items; or you can have a custom HTML-rendered menu without cut/copy/paste. Those are your only choices (unless you ask to install a browser extension, like Google Docs does).

Member

peterflynn commented Jul 22, 2014

Yep -- in-browser, you can have the default native menu with working cut/copy/paste items; or you can have a custom HTML-rendered menu without cut/copy/paste. Those are your only choices (unless you ask to install a browser extension, like Google Docs does).

@ingorichter ingorichter self-assigned this Aug 4, 2014

@ingorichter

This comment has been minimized.

Show comment
Hide comment
@ingorichter

ingorichter Aug 4, 2014

Contributor

Tested on Linux. Menu items have been removed, keyboard shortcuts are still working.

Contributor

ingorichter commented Aug 4, 2014

Tested on Linux. Menu items have been removed, keyboard shortcuts are still working.

ingorichter added a commit that referenced this pull request Aug 4, 2014

Merge pull request #8497 from adobe/pflynn/htmlmenu-noclipboard
Clear up bug #6722 (Linux: menu items cut/copy/paste not working)

@ingorichter ingorichter merged commit 2171d31 into master Aug 4, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@peterflynn peterflynn deleted the pflynn/htmlmenu-noclipboard branch Aug 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment