New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch InlineTimingFunctionEditor's changes #8589

Merged
merged 1 commit into from Aug 4, 2014

Conversation

Projects
None yet
2 participants
@MarcelGerber
Contributor

MarcelGerber commented Jul 29, 2014

Makes the InlineTimingFunctionEditor smoother through batching changes.
Similar to InlineColorEditor's 43004ed.

@redmunds redmunds self-assigned this Jul 31, 2014

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Jul 31, 2014

Contributor

@SAPlayer Undo's are already batched, right? Or is there a change in undo behavior? What change is seen by end user? Only performance, or something more?

Contributor

redmunds commented Jul 31, 2014

@SAPlayer Undo's are already batched, right? Or is there a change in undo behavior? What change is seen by end user? Only performance, or something more?

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Jul 31, 2014

Contributor

@redmunds Yes, it's only performance.

Contributor

MarcelGerber commented Jul 31, 2014

@redmunds Yes, it's only performance.

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Aug 4, 2014

Contributor

@MarcelGerber You'll need to sign the Brackets CLA again with your new id.

Contributor

redmunds commented Aug 4, 2014

@MarcelGerber You'll need to sign the Brackets CLA again with your new id.

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Aug 4, 2014

Contributor

Looks good. Let me know when you've signed the CLA.

Contributor

redmunds commented Aug 4, 2014

Looks good. Let me know when you've signed the CLA.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Aug 4, 2014

Contributor

@redmunds Signed it again

Contributor

MarcelGerber commented Aug 4, 2014

@redmunds Signed it again

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Aug 4, 2014

Contributor

Merging.

Contributor

redmunds commented Aug 4, 2014

Merging.

redmunds added a commit that referenced this pull request Aug 4, 2014

@redmunds redmunds merged commit 2b91194 into adobe:master Aug 4, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@MarcelGerber MarcelGerber deleted the MarcelGerber:inline-timing-function-batch branch Aug 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment