Update getting started (en-us) #8606

Merged
merged 3 commits into from Aug 4, 2014

Projects

None yet

3 participants

@wormeyman
Contributor

I noticed that some of the URL's had changed in the get involved section such as GitHub and Twitter moving to https by default and google added a Hash Bang (#!) while twitter removed theirs.

Also would we want to link to the freenode webchat?

wormeyman added some commits Jul 31, 2014
@wormeyman wormeyman Remove Trailing Space 3bc8a7a
@wormeyman wormeyman Update Get involved URLs to prevent redirects.
Many of the URL's at the bottom have been updated or moved, for example
GitHub and Twitter are https by default now.
6bb606f
@redmunds
Contributor
redmunds commented Aug 4, 2014

Looks good.

Also would we want to link to the freenode webchat?

Sure. http://brackets.io uses http://webchat.freenode.net/?channels=brackets&uio=d4

@redmunds redmunds self-assigned this Aug 4, 2014
@redmunds
Contributor
redmunds commented Aug 4, 2014

Thanks. Merging.

@redmunds redmunds merged commit 0f61fcf into adobe:master Aug 4, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@wormeyman wormeyman deleted the unknown repository branch Aug 4, 2014
@peterflynn
Member

Hmm, we really should have updated all the other languages to match. @wormeyman Do you want to submit a PR that updates the same URLs in all the other locales of the Getting Started project? (Afaik none of these links vary by locale)

@wormeyman
Contributor

Sure @peterflynn I'll Look into it.

@peterflynn
Member

Thanks!

@wormeyman
Contributor

I did my commits on the release branch should i pull against that or the master branch? @peterflynn

edit: https://github.com/wormeyman/brackets/tree/Get-Involved-url-Update

@peterflynn
Member

@wormeyman The release branch is basically closed at this point, so please target at master now. Thanks for the fast response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment