Sprint -> Release #8680

Merged
merged 2 commits into from Sep 9, 2014

Projects

None yet

5 participants

@MarcelGerber
Member

For #7828 and https://trello.com/c/atMTdx6l/1313-brackets-7828-should-be-consistent-about-release-vs-sprint-issue

Replaces most of the occurences of Sprint with Release, maybe even too many.

The only ones I left in place were some unit tests and the non-English translations (to be translated).

@MarcelGerber MarcelGerber and 1 other commented on an outdated diff Aug 6, 2014
src/nls/root/strings.js
@@ -403,7 +403,7 @@ define({
"RELAUNCH_CHROME" : "Relaunch Chrome",
"ABOUT" : "About",
"CLOSE" : "Close",
- "ABOUT_TEXT_LINE1" : "sprint {VERSION_MINOR} {BUILD_TYPE} {VERSION}",
+ "ABOUT_TEXT_LINE1" : "release {VERSION_MAJOR}.{VERSION_MINOR} {BUILD_TYPE} {VERSION}",
@MarcelGerber
MarcelGerber Aug 6, 2014 Member

Should it be uppercase?

@redmunds
redmunds Aug 6, 2014 Contributor

Yes, I think it should be "Release".

@MarcelGerber MarcelGerber commented on the diff Aug 6, 2014
tasks/update-release-number.js
}
-
- packageJSON.version = packageJSON.version.replace(versionNumberRegexp, "$1" + sprint + "$3");
- packageJSON.apiVersion = packageJSON.apiVersion.replace(versionNumberRegexp, "$1" + sprint + "$3");
+
+ packageJSON.version = packageJSON.version.replace(versionNumberRegexp, "$1" + release + "$3");
+ packageJSON.apiVersion = packageJSON.apiVersion.replace(versionNumberRegexp, "$1" + release + "$3");
@MarcelGerber
MarcelGerber Aug 6, 2014 Member

Should it also change the major version?

@dangoor
dangoor Aug 12, 2014 Contributor

We're not adjusting the major version yet. This will need to change when we do so.

@redmunds
Contributor
redmunds commented Aug 6, 2014

@MarcelGerber Thanks for looking at this. There is a similar grunt set-sprint task in the brackets-shell repo that updates several more files that needs to be updated also.

@peterflynn
Member

@ingorichter Does this have any implications with how builds are deployed on brackets.io or the update-notification server?

@MarcelGerber
Member

@redmunds They don't depend on each other, do they? I'm not super used to brackets-shell, and we need another PR there anyway. The trello card linked above mentions some other changes to be done there as well.

@peterflynn Probably not. They already use names like "Release 0.xx" and don't depend on the changes here (which are a Grunt task rename and a UI string change).
The task rename will break automated scripts depending on that task, though.

@ingorichter
Contributor

@peterflynn No, the information for brackets.io is coming from the update notifications. These changes won't break any deployment of new builds.

@redmunds
Contributor

@MarcelGerber We definitely want to update both brackets and brackets-shell, so might as well do them together. Take a look at this pull request to see the files that are updated. They are all data files, so it should be straight forward.

@MarcelGerber MarcelGerber referenced this pull request in adobe/brackets-shell Aug 12, 2014
Merged

Sprint -> Release #462

@ingorichter
Contributor

I'm going to merge #8680 and adobe/brackets-shell#462 after the release of 43. I need to make small breaking changes to the build machine setup.

@ingorichter ingorichter self-assigned this Aug 27, 2014
@redmunds
Contributor

@ingorichter Since you are looking at this, you should take the "Run grunt set-sprint --sprint=N to update sprint number in master branches" task to use as a test.

@redmunds redmunds referenced this pull request Sep 2, 2014
Closed

Update root strings.js #8267

@ingorichter ingorichter merged commit 0f21bf6 into adobe:master Sep 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@ingorichter
Contributor

Thanks @MarcelGerber

@MarcelGerber MarcelGerber deleted the MarcelGerber:sprint-to-release branch Sep 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment