New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint -> Release #8680

Merged
merged 2 commits into from Sep 9, 2014

Conversation

Projects
None yet
5 participants
@MarcelGerber
Contributor

MarcelGerber commented Aug 6, 2014

For #7828 and https://trello.com/c/atMTdx6l/1313-brackets-7828-should-be-consistent-about-release-vs-sprint-issue

Replaces most of the occurences of Sprint with Release, maybe even too many.

The only ones I left in place were some unit tests and the non-English translations (to be translated).

packageJSON.apiVersion = packageJSON.apiVersion.replace(versionNumberRegexp, "$1" + sprint + "$3");
packageJSON.version = packageJSON.version.replace(versionNumberRegexp, "$1" + release + "$3");
packageJSON.apiVersion = packageJSON.apiVersion.replace(versionNumberRegexp, "$1" + release + "$3");

This comment has been minimized.

@MarcelGerber

MarcelGerber Aug 6, 2014

Contributor

Should it also change the major version?

@MarcelGerber

MarcelGerber Aug 6, 2014

Contributor

Should it also change the major version?

This comment has been minimized.

@dangoor

dangoor Aug 12, 2014

Contributor

We're not adjusting the major version yet. This will need to change when we do so.

@dangoor

dangoor Aug 12, 2014

Contributor

We're not adjusting the major version yet. This will need to change when we do so.

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Aug 6, 2014

Contributor

@MarcelGerber Thanks for looking at this. There is a similar grunt set-sprint task in the brackets-shell repo that updates several more files that needs to be updated also.

Contributor

redmunds commented Aug 6, 2014

@MarcelGerber Thanks for looking at this. There is a similar grunt set-sprint task in the brackets-shell repo that updates several more files that needs to be updated also.

@peterflynn

This comment has been minimized.

Show comment
Hide comment
@peterflynn

peterflynn Aug 7, 2014

Member

@ingorichter Does this have any implications with how builds are deployed on brackets.io or the update-notification server?

Member

peterflynn commented Aug 7, 2014

@ingorichter Does this have any implications with how builds are deployed on brackets.io or the update-notification server?

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Aug 7, 2014

Contributor

@redmunds They don't depend on each other, do they? I'm not super used to brackets-shell, and we need another PR there anyway. The trello card linked above mentions some other changes to be done there as well.

@peterflynn Probably not. They already use names like "Release 0.xx" and don't depend on the changes here (which are a Grunt task rename and a UI string change).
The task rename will break automated scripts depending on that task, though.

Contributor

MarcelGerber commented Aug 7, 2014

@redmunds They don't depend on each other, do they? I'm not super used to brackets-shell, and we need another PR there anyway. The trello card linked above mentions some other changes to be done there as well.

@peterflynn Probably not. They already use names like "Release 0.xx" and don't depend on the changes here (which are a Grunt task rename and a UI string change).
The task rename will break automated scripts depending on that task, though.

@ingorichter

This comment has been minimized.

Show comment
Hide comment
@ingorichter

ingorichter Aug 7, 2014

Contributor

@peterflynn No, the information for brackets.io is coming from the update notifications. These changes won't break any deployment of new builds.

Contributor

ingorichter commented Aug 7, 2014

@peterflynn No, the information for brackets.io is coming from the update notifications. These changes won't break any deployment of new builds.

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Aug 12, 2014

Contributor

@MarcelGerber We definitely want to update both brackets and brackets-shell, so might as well do them together. Take a look at this pull request to see the files that are updated. They are all data files, so it should be straight forward.

Contributor

redmunds commented Aug 12, 2014

@MarcelGerber We definitely want to update both brackets and brackets-shell, so might as well do them together. Take a look at this pull request to see the files that are updated. They are all data files, so it should be straight forward.

@MarcelGerber MarcelGerber referenced this pull request Aug 12, 2014

Merged

Sprint -> Release #462

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber
Contributor

MarcelGerber commented Aug 12, 2014

@ingorichter

This comment has been minimized.

Show comment
Hide comment
@ingorichter

ingorichter Aug 27, 2014

Contributor

I'm going to merge #8680 and adobe/brackets-shell#462 after the release of 43. I need to make small breaking changes to the build machine setup.

Contributor

ingorichter commented Aug 27, 2014

I'm going to merge #8680 and adobe/brackets-shell#462 after the release of 43. I need to make small breaking changes to the build machine setup.

@ingorichter ingorichter self-assigned this Aug 27, 2014

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Aug 27, 2014

Contributor

@ingorichter Since you are looking at this, you should take the "Run grunt set-sprint --sprint=N to update sprint number in master branches" task to use as a test.

Contributor

redmunds commented Aug 27, 2014

@ingorichter Since you are looking at this, you should take the "Run grunt set-sprint --sprint=N to update sprint number in master branches" task to use as a test.

@redmunds redmunds referenced this pull request Sep 2, 2014

Closed

Update root strings.js #8267

ingorichter added a commit that referenced this pull request Sep 9, 2014

@ingorichter ingorichter merged commit 0f21bf6 into adobe:master Sep 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@ingorichter

This comment has been minimized.

Show comment
Hide comment
@ingorichter
Contributor

ingorichter commented Sep 9, 2014

Thanks @MarcelGerber

@MarcelGerber MarcelGerber deleted the MarcelGerber:sprint-to-release branch Sep 9, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment