Fix outdated comments in StringUtils `truncate()` #8707

Merged
merged 2 commits into from Aug 11, 2014

Projects

None yet

2 participants

@le717
Contributor
le717 commented Aug 9, 2014

I must have stared at this code so much I did not realize they were outdated until right now. 😄

@peterflynn peterflynn commented on an outdated diff Aug 11, 2014
src/utils/StringUtils.js
* @param {string} str Text to be truncated.
- * @param {number} len Length to which text should be limited.
- * @return {string} Returns truncated text only if it was changed.
+ * @param {number} len Length to which text should be truncated
+ * @return {string} Returns truncated text only if it was changed
@peterflynn
peterflynn Aug 11, 2014 Member

Nit: can you change this to {?string} to indicate that it can return undefined?

@peterflynn
Member

@le717 Just that one suggestion, looks fine to merge other than that

@le717
Contributor
le717 commented Aug 11, 2014

@peterflynn Done.

@peterflynn
Member

Looks good -- thanks!

@peterflynn peterflynn merged commit 165e459 into adobe:master Aug 11, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@le717 le717 deleted the le717:fix-truncate-comments branch Aug 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment