New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Working Files locale-aware #8971

Merged
merged 7 commits into from Sep 24, 2014

Conversation

Projects
None yet
3 participants
@MarcelGerber
Contributor

MarcelGerber commented Sep 5, 2014

For #8955.
Tested with German and Swedish locale.

@pthiess

This comment has been minimized.

Show comment
Hide comment
@pthiess

pthiess Sep 5, 2014

Member

@ingorichter Looks like a good enhancement to me.

Member

pthiess commented Sep 5, 2014

@ingorichter Looks like a good enhancement to me.

Show outdated Hide outdated src/file/FileUtils.js Outdated
@@ -230,6 +230,9 @@ define(function (require, exports, module) {
context.translated = true;
context.translatedLangs =
info.metadata.i18n.map(function (value) {
if (value === "root") {

This comment has been minimized.

@MarcelGerber

MarcelGerber Sep 5, 2014

Contributor

This is a little offtopic, but it normalizes "i18n": ["root"] to "i18n": ["en"] in package.json

@MarcelGerber

MarcelGerber Sep 5, 2014

Contributor

This is a little offtopic, but it normalizes "i18n": ["root"] to "i18n": ["en"] in package.json

@ingorichter

This comment has been minimized.

Show comment
Hide comment
@ingorichter

ingorichter Sep 12, 2014

Does this by intent return only en instead of en-us?

Does this by intent return only en instead of en-us?

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Sep 12, 2014

Owner

Yes, en-us can't be translated as the only nls entry is LOCALE_EN.

Owner

MarcelGerber replied Sep 12, 2014

Yes, en-us can't be translated as the only nls entry is LOCALE_EN.

@ingorichter

This comment has been minimized.

Show comment
Hide comment
@ingorichter

ingorichter Sep 15, 2014

Contributor

@MarcelGerber could you please add a couple of tests to FileUtils-tests.js to verify that this fixes #8955? Thanks.

Contributor

ingorichter commented Sep 15, 2014

@MarcelGerber could you please add a couple of tests to FileUtils-tests.js to verify that this fixes #8955? Thanks.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Sep 16, 2014

Contributor

Added unit tests.

Contributor

MarcelGerber commented Sep 16, 2014

Added unit tests.

Show outdated Hide outdated test/spec/FileUtils-test.js Outdated
Show outdated Hide outdated test/spec/FileUtils-test.js Outdated
@ingorichter

This comment has been minimized.

Show comment
Hide comment
@ingorichter

ingorichter Sep 24, 2014

Contributor

@MarcelGerber I'm done with the review. Looks good to me and is definitely a great improvement.

Contributor

ingorichter commented Sep 24, 2014

@MarcelGerber I'm done with the review. Looks good to me and is definitely a great improvement.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Sep 24, 2014

Contributor

@ingorichter I'm done. Please let me know if that newline should be removed.

Contributor

MarcelGerber commented Sep 24, 2014

@ingorichter I'm done. Please let me know if that newline should be removed.

@ingorichter

This comment has been minimized.

Show comment
Hide comment
@ingorichter

ingorichter Sep 24, 2014

Contributor

@MarcelGerber we need to get better with coding and formatting conventions in general. Thanks for changing this.

Contributor

ingorichter commented Sep 24, 2014

@MarcelGerber we need to get better with coding and formatting conventions in general. Thanks for changing this.

ingorichter added a commit that referenced this pull request Sep 24, 2014

@ingorichter ingorichter merged commit 9abc718 into adobe:master Sep 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@MarcelGerber MarcelGerber deleted the MarcelGerber:workingset-sort-locale branch Sep 24, 2014

@pthiess pthiess added this to the Release 0.44 milestone Sep 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment