New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing cursor !important to allow themes easily override cursor colors #9061

Merged
merged 1 commit into from Sep 24, 2014

Conversation

Projects
None yet
3 participants
@MiguelCastillo
Contributor

MiguelCastillo commented Sep 11, 2014

So all themes that customize the cursor must have a !important in order to override the default cursor, because that has a !important. So, let's remove the !important in the default cursor to reduce friction when authoring themes.

@MiguelCastillo MiguelCastillo changed the title from Removing cursor !important so allow themes easily override cursor colors to Removing cursor !important to allow themes easily override cursor colors Sep 11, 2014

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Sep 24, 2014

Contributor

Looks good. Merging.

Contributor

redmunds commented Sep 24, 2014

Looks good. Merging.

redmunds added a commit that referenced this pull request Sep 24, 2014

Merge pull request #9061 from adobe/miguel/themecursor
Removing cursor !important to allow themes easily override cursor colors

@redmunds redmunds merged commit 7de0f3b into master Sep 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@redmunds redmunds deleted the miguel/themecursor branch Sep 24, 2014

@redmunds redmunds self-assigned this Sep 24, 2014

@MiguelCastillo

This comment has been minimized.

Show comment
Hide comment
@MiguelCastillo

MiguelCastillo Sep 24, 2014

Contributor

Thanks! This is going to make codemirror themes real happy :)

Contributor

MiguelCastillo commented Sep 24, 2014

Thanks! This is going to make codemirror themes real happy :)

@pthiess pthiess added this to the Release 0.44 milestone Sep 25, 2014

@Denisov21 Denisov21 referenced this pull request Sep 26, 2014

Closed

See important issue #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment