Removing cursor !important to allow themes easily override cursor colors #9061

Merged
merged 1 commit into from Sep 24, 2014

Projects

None yet

3 participants

@MiguelCastillo
Member

So all themes that customize the cursor must have a !important in order to override the default cursor, because that has a !important. So, let's remove the !important in the default cursor to reduce friction when authoring themes.

@MiguelCastillo MiguelCastillo changed the title from Removing cursor !important so allow themes easily override cursor colors to Removing cursor !important to allow themes easily override cursor colors Sep 11, 2014
@redmunds
Contributor

Looks good. Merging.

@redmunds redmunds merged commit 7de0f3b into master Sep 24, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@redmunds redmunds deleted the miguel/themecursor branch Sep 24, 2014
@redmunds redmunds self-assigned this Sep 24, 2014
@MiguelCastillo
Member

Thanks! This is going to make codemirror themes real happy :)

@pthiess pthiess added this to the Release 0.44 milestone Sep 25, 2014
@Denisov21 Denisov21 referenced this pull request in Brackets-Themes/Earth Sep 26, 2014
Closed

See important issue #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment