Skip to content
This repository has been archived by the owner on Sep 25, 2019. It is now read-only.

Commit

Permalink
Disable part of InProcessBrowserTest.InjectIDBKey to prepare for upst…
Browse files Browse the repository at this point in the history
…ream changes.

InProcessBrowserTest.InjectIDBKey depends on internal details about the format produced by WebSerializedScriptValue; this format will change should https://bugs.webkit.org/show_bug.cgi?id=63481 land. After the WebKit change is complete, this test will be re-enabled in a way that works with the new format.

BUG=None
TEST=This is a test modification.

Review URL: http://codereview.chromium.org/7400030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93053 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
levin@chromium.org committed Jul 19, 2011
1 parent e0d336e commit 0a7a4f5
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions AUTHORS
Expand Up @@ -115,3 +115,4 @@ ruben <chromium@hybridsource.org>
NVIDIA Corporation <*@nvidia.com>
Torsten Kurbad <google@tk-webart.de>
Max Perepelitsyn <pph34r@gmail.com>
Luke Zarko <lukezarko@gmail.com>
4 changes: 3 additions & 1 deletion chrome/browser/idbbindingutilities_browsertest.cc
Expand Up @@ -338,7 +338,9 @@ IN_PROC_BROWSER_TEST_F(InProcessBrowserTest, InjectIDBKey) {

ScopedIDBKeyPathHelper scoped_helper;
scoped_helper.SetExpectedValue(expected_value);
scoped_helper.CheckInjectValue(key, value, UTF8ToUTF16("bar"));
// TODO(lukezarko@gmail.com): re-enable this after the changes described at
// https://bugs.webkit.org/show_bug.cgi?id=63481 land.
// scoped_helper.CheckInjectValue(key, value, UTF8ToUTF16("bar"));

scoped_helper.SetExpectedValue(SerializedScriptValue()); // Expect null.
scoped_helper.CheckInjectValue(key, value, UTF8ToUTF16("bad.key.path"));
Expand Down

0 comments on commit 0a7a4f5

Please sign in to comment.