Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hlx publish should warn, not fail when helix-logging fails #890

Closed
trieloff opened this issue May 15, 2019 · 1 comment · Fixed by #1183
Closed

hlx publish should warn, not fail when helix-logging fails #890

trieloff opened this issue May 15, 2019 · 1 comment · Fixed by #1183
Labels
bug Something isn't working good first issue Good for newcomers released

Comments

@trieloff
Copy link
Contributor

As the ongoing incident means that helix publish will be affected for new sites, I suggest we warn instead of fail when the helix-logging service cannot be used.
@trieloff trieloff added the bug Something isn't working label May 15, 2019
@kptdobe kptdobe added the good first issue Good for newcomers label Aug 28, 2019
@medusalix medusalix mentioned this issue Oct 15, 2019
Merged
2 tasks
@adobe-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 5.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(publish): warn if remote logging fails
3 participants
@trieloff @kptdobe @adobe-bot