From 57d66436813bf77fe8d4359677760e6147837e9d Mon Sep 17 00:00:00 2001 From: Lars Trieloff Date: Tue, 24 Mar 2020 08:36:12 +0000 Subject: [PATCH 1/4] test(post-deploy): more debug logging --- test/post-deploy.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/post-deploy.test.js b/test/post-deploy.test.js index 3c80e1ec..b3184c03 100644 --- a/test/post-deploy.test.js +++ b/test/post-deploy.test.js @@ -37,10 +37,10 @@ describe('Post-Deploy Tests', () => { .request('https://adobeioruntime.net/') .get(`${getbaseurl()}/https://blogs.adobe.com/psirt/?feed=atom`) .then((response) => { - console.log(response); + console.log('JSON:', response.json); + console.log('Response:', Object.keys(response)); expect(response).to.have.status(200); expect(response).to.be.json; - console.log(response.json); }).catch((e) => { throw e; }); From 74de0a1dd1dc440d5205d6a89676fccb2a603556 Mon Sep 17 00:00:00 2001 From: Lars Trieloff Date: Tue, 24 Mar 2020 08:40:48 +0000 Subject: [PATCH 2/4] test(post-deploy): log response body --- test/post-deploy.test.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/post-deploy.test.js b/test/post-deploy.test.js index b3184c03..77c620ca 100644 --- a/test/post-deploy.test.js +++ b/test/post-deploy.test.js @@ -37,7 +37,8 @@ describe('Post-Deploy Tests', () => { .request('https://adobeioruntime.net/') .get(`${getbaseurl()}/https://blogs.adobe.com/psirt/?feed=atom`) .then((response) => { - console.log('JSON:', response.json); + console.log('URL:', response.req.uri); + console.log('JSON:', response.body); console.log('Response:', Object.keys(response)); expect(response).to.have.status(200); expect(response).to.be.json; From db45763fe8c9883e52cc5685709d43b55dced540 Mon Sep 17 00:00:00 2001 From: Lars Trieloff Date: Tue, 24 Mar 2020 08:52:55 +0000 Subject: [PATCH 3/4] fix(deploy): use correct service name for wsk deployments --- package.json | 2 +- test/post-deploy.test.js | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 78d6baa1..bd1e72b1 100644 --- a/package.json +++ b/package.json @@ -18,7 +18,7 @@ "deploy-ci": "wsk-builder -v --deploy --test=/_status_check/healthcheck.json --pkgVersion=ci$CIRCLE_BUILD_NUM -l ci" }, "wsk": { - "name": "helix-services-private/helix-data-embed@${version}", + "name": "helix-services-private/data-embed@${version}", "linksPackage": "helix-services" }, "repository": { diff --git a/test/post-deploy.test.js b/test/post-deploy.test.js index 77c620ca..ea4cb706 100644 --- a/test/post-deploy.test.js +++ b/test/post-deploy.test.js @@ -37,9 +37,10 @@ describe('Post-Deploy Tests', () => { .request('https://adobeioruntime.net/') .get(`${getbaseurl()}/https://blogs.adobe.com/psirt/?feed=atom`) .then((response) => { - console.log('URL:', response.req.uri); + console.log('URL:', response.req.path); console.log('JSON:', response.body); console.log('Response:', Object.keys(response)); + expect(response.body).to.be.an('array').that.has.length(10); expect(response).to.have.status(200); expect(response).to.be.json; }).catch((e) => { From f06792828b7f8704357c0e9e8f1541e1261b6467 Mon Sep 17 00:00:00 2001 From: Lars Trieloff Date: Tue, 24 Mar 2020 08:57:07 +0000 Subject: [PATCH 4/4] refactor(post-deploy): remove debug output --- test/post-deploy.test.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/test/post-deploy.test.js b/test/post-deploy.test.js index ea4cb706..93b2f3da 100644 --- a/test/post-deploy.test.js +++ b/test/post-deploy.test.js @@ -37,12 +37,9 @@ describe('Post-Deploy Tests', () => { .request('https://adobeioruntime.net/') .get(`${getbaseurl()}/https://blogs.adobe.com/psirt/?feed=atom`) .then((response) => { - console.log('URL:', response.req.path); - console.log('JSON:', response.body); - console.log('Response:', Object.keys(response)); + expect(response).to.be.json; expect(response.body).to.be.an('array').that.has.length(10); expect(response).to.have.status(200); - expect(response).to.be.json; }).catch((e) => { throw e; });