Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter for skipping extraneous file check #58

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

baheath
Copy link
Collaborator

@baheath baheath commented Mar 30, 2020

Add parameter for skipping extraneous file check.

Copy link
Contributor

@fosterbrereton fosterbrereton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -55,6 +55,7 @@ static inline bool is_tag(const std::string& s) {

struct emit_options {
attribute_category _tested_by;
bool _ignore_extraneous_files;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These may want to have default parameters.

@baheath baheath merged commit 0c87c78 into master Mar 30, 2020
@baheath baheath deleted the bheath/ignore-extraneous-files branch March 30, 2020 23:43
@baheath baheath restored the bheath/ignore-extraneous-files branch April 6, 2020 20:41
@baheath baheath deleted the bheath/ignore-extraneous-files branch May 20, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants