Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NUI-921 Initial actions workflow #17

Merged
merged 2 commits into from Nov 24, 2020
Merged

NUI-921 Initial actions workflow #17

merged 2 commits into from Nov 24, 2020

Conversation

tmathern
Copy link
Member

@tmathern tmathern commented Nov 19, 2020 •
edited

Description

Uses Github actions to run unit tests for supported node versions.

Fixes #NUI-921

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • CI/CD

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tmathern tmathern self-assigned this Nov 19, 2020
@tmathern tmathern changed the title Initial actions workflow NUI-921 Initial actions workflow Nov 19, 2020
alexkli
alexkli approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@alexkli alexkli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same sizewatcher suggestion as in adobe/asset-compute-client#40 (comment)

@tmathern tmathern merged commit a486f54 into master Nov 24, 2020
@tmathern tmathern deleted the actions-workflow branch November 24, 2020 00:30
@adobe-bot
Copy link

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkli alexkli alexkli approved these changes

@DrGirlfriend DrGirlfriend Awaiting requested review from DrGirlfriend

@jdelbick jdelbick Awaiting requested review from jdelbick

Assignees

@tmathern tmathern

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tmathern @adobe-bot @alexkli