Skip to content

Conversation

@kmaschi
Copy link
Member

@kmaschi kmaschi commented Oct 24, 2024

Description

Updated to dynamic import as part of changes to support edge compatibility of hooks.

Related Issue

CEXT-2904

Motivation and Context

Previous the package was using dynamic require to import and compose hook functions, which is not compatible with edge runtime.

How Has This Been Tested?

  • Link to aio plugin for local development.
  • Link to mesh builder.
  • Link to legacy api mesh.
  • Link to edge api mesh.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

jward-magento
jward-magento previously approved these changes Oct 28, 2024
amolina-adobe
amolina-adobe previously approved these changes Oct 28, 2024
@kmaschi kmaschi merged commit 5c467e5 into develop Oct 29, 2024
3 checks passed
@kmaschi kmaschi deleted the feature/CEXT-2904-local-hooks-edge branch October 29, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants