feat: add hasSquareCorners prop to bar chart #263
Conversation
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-263 |
1 similar comment
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-263 |
|
|
||
| // Square radius should have values of 0 | ||
| expect(squareRadius).toEqual( | ||
| expect.objectContaining({ |
There was a problem hiding this comment.
I didn't know about expect.objectContaining. Very cool. The more you know.
There was a problem hiding this comment.
It's a good way to only check about the properties you care about, regardless of the rest of the object shape.
| const { type, lineWidth, metric, hasSquareCorners } = props; | ||
| const value = hasSquareCorners ? 0 : Math.max(1, CORNER_RADIUS - getLineWidthPixelsFromLineWidth(lineWidth) / 2); |
|
Can you add one thing? In |
|
All of our props that have default values, we update the type so these are no longer optional when used within our code. That way you never have to check if something exists, you know it will. I realize for a boolean prop it's less critical but for consistency it's nice even on boolean props. |
|
Lastly can you update the prop table in the docs: https://github.com/adobe/react-spectrum-charts/wiki/Bar. Just add in the new prop. Simple update. |
|
|
🎨 Storybook -> https://opensource.adobe.com/react-spectrum-charts/PR-263 |
Description
Adding
hasSquareCornersprop to allow bar charts to render with square tops.Related Issue
Adobe Jira ticket AN-338678
Motivation and Context
This is needed to allow square tops for an Adobe Product Analytics feature called "Forked Funnel"
How Has This Been Tested?
Tested in unit tests in this request
Screenshots (if appropriate):
Types of changes
Checklist: