Skip to content

Fix ActionGroup CSS specificity #2023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Fix ActionGroup CSS specificity #2023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/@adobe/spectrum-css-temp/components/actiongroup/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,8 @@ governing permissions and limitations under the License.
}

.spectrum-ActionGroup-menu {
.spectrum-ActionGroup-menu-chevron {
/* specificity must be higher than `.spectrum-ActionButton .spectrum-Icon` */
svg.spectrum-ActionGroup-menu-chevron {
Copy link
Member

@snowystinger snowystinger Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think previously we've handled it like
.spectrum-ActionGroup-menu-chevron.spectrum-ActionGroup-menu-chevron otherwise we could run into an issue if someone is doing flags and uses an img

Copy link
Member Author

@devongovett devongovett Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a hard coded chevron, not user provided...

Copy link
Member

@snowystinger snowystinger Jun 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o, ok, then carry on

order: 2;
padding-inline-start: 0;
padding-inline-end: var(--spectrum-actionbutton-icon-padding-x);
Expand Down