Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing peer dependencies #2201

Merged
merged 1 commit into from Aug 3, 2021
Merged

Fix missing peer dependencies #2201

merged 1 commit into from Aug 3, 2021

Conversation

devongovett
Copy link
Member

Fixes #2188.

Yarn 2 is very strict about peer dependencies. Peers declared in a package must also be declared in all parent packages, recursively. I wrote a script to add the missing peer deps to all packages following these requirements because it's too hard to do manually.

@adobe-bot
Copy link

Build successful! 🎉

@dannify dannify merged commit 3d09b10 into main Aug 3, 2021
@dannify dannify deleted the fix-peers branch August 3, 2021 20:40
@dimitrisnl
Copy link

Hey @devongovett - Why not use ^17.0.2 instead of 17.0.0-rc.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing peer dependencies (mostly on react and react-dom)
4 participants