Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action group button missing border #2710

Merged
merged 4 commits into from Dec 24, 2021

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Dec 23, 2021

Closes

We use isolation in a couple places, the ActionGroup is very contained, so I don't think setting isolation on it should cause an issue. It allows us to make a very small change to support showing the correct border.

potentially a way to address #2653

Another option we could do is to bump the z-index of everything except the disabled case. This might interfere if someone is using z-index elsewhere in their app, though typically people reach for like, 10-100-999999, sooo that should be fairly safe too since we'd only go to about 5.
And yet another option could be to track which disabled buttons have non-disabled buttons before them and add the regular border to their leading edge. This has more room for error because it only applies to a couple of cases, we wouldn't want to do it when the buttons don't share an edge.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@adobe-bot
Copy link

Build successful! 🎉

Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me 🤷

@adobe-bot
Copy link

Build successful! 🎉

@dannify dannify merged commit 2842ff5 into main Dec 24, 2021
@dannify dannify deleted the another-maverick-fix/action_group_button branch December 24, 2021 00:26
@LFDanLu LFDanLu mentioned this pull request Jan 12, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants