action group button missing border #2710
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
We use isolation in a couple places, the ActionGroup is very contained, so I don't think setting isolation on it should cause an issue. It allows us to make a very small change to support showing the correct border.
potentially a way to address #2653
Another option we could do is to bump the z-index of everything except the disabled case. This might interfere if someone is using z-index elsewhere in their app, though typically people reach for like, 10-100-999999, sooo that should be fairly safe too since we'd only go to about 5.
And yet another option could be to track which disabled buttons have non-disabled buttons before them and add the regular border to their leading edge. This has more room for error because it only applies to a couple of cases, we wouldn't want to do it when the buttons don't share an edge.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: