Skip to content

Conversation

@snowystinger
Copy link
Member

@snowystinger snowystinger commented Mar 13, 2020

Temporary workaround for docs build issue
Closes https://jira.corp.adobe.com/browse/RSP-1613

Verification done in Progress Circle PR
here's the build btw with the no scope hoisting, things aren't perfect (sidenav is out of order) but the individual pages appear to display correctly https://reactspectrum.blob.core.windows.net/reactspectrum/67cdab621d0c186b305d9f2d958294ff541d5232/docs/react-spectrum/Well.html
this is from this pull #239
which if you scroll up to the previous docs build, you can see that the pages starting at progress bar are messed up

✅ Pull Request Checklist:

  • Included link to corresponding Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Team:

@adobe-bot
Copy link

Build successful! 🎉

ktabors
ktabors previously approved these changes Mar 13, 2020
@ktabors ktabors dismissed their stale review March 13, 2020 20:33

Found an issue

@ktabors
Copy link
Member

ktabors commented Mar 13, 2020

I tested this on my local by adding no scope hoisting to yarn build:docs. You added it to the build target, I'm wondering it it should be on the website target. I found the problem in the statuslight page of this docs website artifact fhttps://reactspectrum.blob.core.windows.net/reactspectrum/b8e79f3c890d87316b1d0db6aee94bc22af6f1b2/docs/react-spectrum/StatusLight.html

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@dannify dannify merged commit 2c465f8 into master Mar 13, 2020
@dannify dannify deleted the temp-no-scope-hoist branch March 13, 2020 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants