Skip to content

Fixing falsy checks in TableKeyboardDelegate #2846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Fixing falsy checks in TableKeyboardDelegate #2846

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c210957
fixing if checks in TableKeyboardDelegate
LFDanLu Feb 11, 2022
a17510f
Merge branch 'main' into audit_fix_falsy_key
LFDanLu Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/@react-aria/table/src/TableKeyboardDelegate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export class TableKeyboardDelegate<T> extends GridKeyboardDelegate<T, TableColle
}

let firstKey = this.getFirstKey();
if (!firstKey) {
if (firstKey == null) {
return;
}

Expand Down Expand Up @@ -65,7 +65,7 @@ export class TableKeyboardDelegate<T> extends GridKeyboardDelegate<T, TableColle

// only return above row key if not header row
let superKey = super.getKeyAbove(key);
if (superKey && this.collection.getItem(superKey).type !== 'headerrow') {
if (superKey != null && this.collection.getItem(superKey).type !== 'headerrow') {
return superKey;
}

Expand Down Expand Up @@ -152,7 +152,7 @@ export class TableKeyboardDelegate<T> extends GridKeyboardDelegate<T, TableColle

let collection = this.collection;
let key = fromKey ?? this.getFirstKey();
if (!key) {
if (key == null) {
return null;
}

Expand Down