Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3299): SearchAutocomplete/SearchWithin support icon prop override #3300

Merged
merged 6 commits into from Aug 3, 2022

Conversation

majornista
Copy link
Collaborator

@majornista majornista commented Jul 12, 2022

Closes #3299

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue SearchAutocomplete: support icon prop override #3299 .
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  1. Open https://reactspectrum.blob.core.windows.net/reactspectrum/61069c227ee21cbb713035237b414e39ca813c09/storybook/index.html?path=/story/searchautocomplete--icon-filter&providerSwitcher-toastPosition=bottom
  2. Verify the SearchAutocomplete uses the Filter icon.
  3. Open https://reactspectrum.blob.core.windows.net/reactspectrum/61069c227ee21cbb713035237b414e39ca813c09/storybook/index.html?path=/story/searchautocomplete--icon-null&providerSwitcher-toastPosition=bottom
  4. Verify the SearchAutocomplete does not render an icon.
  5. Repeat steps 1-4 using a mobile user agent to verify that the behavior is similar with MobileSearchAutoComplete.
  6. Open https://reactspectrum.blob.core.windows.net/reactspectrum/61069c227ee21cbb713035237b414e39ca813c09/storybook/index.html?path=/story/searchfield--icon-null&providerSwitcher-toastPosition=bottom
  7. Verify the SearchField does not render an icon.
  8. Open https://reactspectrum.blob.core.windows.net/reactspectrum/61069c227ee21cbb713035237b414e39ca813c09/storybook/index.html?path=/story/searchfield--isquiet-icon-null&providerSwitcher-toastPosition=bottom
  9. Verify the quiet SearchField does not render an icon.
  10. Open https://reactspectrum.blob.core.windows.net/reactspectrum/61069c227ee21cbb713035237b414e39ca813c09/storybook/index.html?path=/story/searchwithin--icon-filter&providerSwitcher-toastPosition=bottom
  11. Verify the SearchWithin uses the Filter icon.
  12. Open https://reactspectrum.blob.core.windows.net/reactspectrum/61069c227ee21cbb713035237b414e39ca813c09/storybook/index.html?path=/story/searchwithin--icon-null&providerSwitcher-toastPosition=bottom
  13. Verify the SearchWithin does not render an icon.

🧢 Your Project:

Adobe/Accessibility

@adobe-bot
Copy link

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, tested on Chrome, FF, Safari, and iOS Safari.

One thing, I believe SearchWithin may be or has already been deprecated, so it might be better not to include the change in this. I'm not opposed to including it, but someone else may have an objection.

If you can add a chromatic story for each of these, I'm good to approve.

@adobe-bot
Copy link

@adobe-bot
Copy link

reidbarber
reidbarber previously approved these changes Jul 22, 2022
@adobe-bot
Copy link

@dannify dannify merged commit ec22053 into main Aug 3, 2022
@dannify dannify deleted the Issue-3299-SearchAutocomplete-icon branch August 3, 2022 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchAutocomplete: support icon prop override
5 participants