New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(#3299): SearchAutocomplete/SearchWithin support icon prop override #3300
Conversation
Build successful! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, tested on Chrome, FF, Safari, and iOS Safari.
One thing, I believe SearchWithin may be or has already been deprecated, so it might be better not to include the change in this. I'm not opposed to including it, but someone else may have an objection.
If you can add a chromatic story for each of these, I'm good to approve.
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
Closes #3299
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
Adobe/Accessibility