Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ListView drag preview styles for density #3493

Merged
merged 2 commits into from Sep 9, 2022
Merged

Fix ListView drag preview styles for density #3493

merged 2 commits into from Sep 9, 2022

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Sep 8, 2022 •
edited

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Go to a ListView -> Drag and Drop story and use controls to change density.

Check that drag previews for compact and spacious are correct.

🧢 Your Project:

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

@reidbarber reidbarber merged commit 5f16c3f into main Sep 9, 2022
@reidbarber reidbarber deleted the listview-dragpreview-density branch September 9, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@ktabors ktabors ktabors approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@reidbarber @adobe-bot @devongovett @ktabors