Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provider shouldn't disable buttons inside dialogs #3587

Merged
merged 2 commits into from Oct 3, 2022
Merged

Provider shouldn't disable buttons inside dialogs #3587

merged 2 commits into from Oct 3, 2022

Conversation

snowystinger
Copy link
Member

Closes
Found in testing session

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@adobe-bot
Copy link

Build successful! 🎉

reidbarber
reidbarber approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ktabors
ktabors reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@ktabors ktabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on iPad and desktop chrome. On iPad I'm able to close the dialog with the close button. Also tested the dialog story with form elements to make sure adding isDisabled={false} to the Provider didn't do anything weird to form elements.

packages/@react-spectrum/form/test/Form.test.js Show resolved Hide resolved
packages/@react-spectrum/form/test/Form.test.js Show resolved Hide resolved
@snowystinger snowystinger merged commit 4ffc040 into main Oct 3, 2022
@snowystinger snowystinger deleted the provider-shouldn't-disable-buttons-inside-dialogs branch October 3, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktabors ktabors ktabors approved these changes

@reidbarber reidbarber reidbarber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@snowystinger @adobe-bot @ktabors @reidbarber