From d67e4f939de642210afadee3621317d03e0b78b3 Mon Sep 17 00:00:00 2001 From: Daniel Lu Date: Tue, 5 Sep 2023 17:25:23 -0700 Subject: [PATCH] Remove erroneous accessibility color contrast ignore rule investigated, turns out it is a legitimate color contrast problem --- .storybook/test-runner.js | 4 ---- packages/@react-spectrum/datepicker/src/DatePickerSegment.tsx | 3 +-- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/.storybook/test-runner.js b/.storybook/test-runner.js index 09938c27376..a5784c77de4 100644 --- a/.storybook/test-runner.js +++ b/.storybook/test-runner.js @@ -20,10 +20,6 @@ module.exports = { await configureAxe(page, { // TODO: Ideally would have a selector target for the storybook's sb main body element rules: [ - { - id: 'color-contrast', - selector: 'body *:not([data-a11y-ignore="color-contrast"])' - }, { id: 'aria-hidden-focus', selector: 'body *:not([data-a11y-ignore="aria-hidden-focus"])', diff --git a/packages/@react-spectrum/datepicker/src/DatePickerSegment.tsx b/packages/@react-spectrum/datepicker/src/DatePickerSegment.tsx index a8873d78439..8250fe92641 100644 --- a/packages/@react-spectrum/datepicker/src/DatePickerSegment.tsx +++ b/packages/@react-spectrum/datepicker/src/DatePickerSegment.tsx @@ -65,8 +65,7 @@ function EditableSegment({segment, state}: DatePickerSegmentProps) { minWidth: segment.maxValue != null ? String(segment.maxValue).length + 'ch' : null }} data-testid={segment.type}> - {/* TODO: double check this, color contrast issue with quiet placeholder */} - + {segment.isPlaceholder ? '' : segment.text} );