From 7525e66ff9f01a814f065bdf7992c14db21d6f85 Mon Sep 17 00:00:00 2001 From: Daniel Lu Date: Tue, 27 Aug 2024 16:04:06 -0700 Subject: [PATCH 01/12] roughly got the chromatic stories for S1 and S2 working --- .chromatic/.parcelrc | 8 +++++++- .chromatic/main.js | 5 ++++- packages/@react-spectrum/s2/stories/Checkbox.stories.tsx | 2 +- .../@react-spectrum/s2/stories/SearchField.stories.tsx | 7 +++---- packages/@react-spectrum/s2/stories/Slider.stories.tsx | 4 ++-- packages/@react-spectrum/s2/stories/Switch.stories.tsx | 2 +- packages/@react-spectrum/s2/stories/TextField.stories.tsx | 6 +++--- 7 files changed, 21 insertions(+), 13 deletions(-) diff --git a/.chromatic/.parcelrc b/.chromatic/.parcelrc index 81677b70840..86e08486da1 100644 --- a/.chromatic/.parcelrc +++ b/.chromatic/.parcelrc @@ -2,10 +2,16 @@ "extends": "@parcel/config-default", "resolvers": ["@parcel/resolver-glob", "parcel-resolver-storybook", "..."], "transformers": { + "packages/@react-spectrum/s2/{src,stories}/*.{js,mjs,jsm,jsx,es6,cjs,ts,tsx}": ["parcel-transformer-react-docgen-typescript", "..."], + "illustration:*.svg": ["@react-spectrum/parcel-transformer-s2-icon"], + "packages/@react-spectrum/s2/s2wf-icons/**/*.svg": ["@react-spectrum/parcel-transformer-s2-icon"], "packages/*/*/intl/*.json": ["parcel-transformer-intl"], + // Disable PostCSS from running over style macro output + "packages/@react-spectrum/s2/**/*.css": ["@parcel/transformer-css"], "*.{js,mjs,jsm,jsx,es6,cjs,ts,tsx}": [ "@parcel/transformer-js", "@parcel/transformer-react-refresh-wrap" - ] + ], + "packages/@react-spectrum/s2/**/*.svg": ["@parcel/transformer-svg-react"], } } diff --git a/.chromatic/main.js b/.chromatic/main.js index cd268dee236..0d31731266d 100644 --- a/.chromatic/main.js +++ b/.chromatic/main.js @@ -4,7 +4,10 @@ module.exports = { name: "storybook-react-parcel", options: {}, }, - stories: ['../packages/**/chromatic/**/*.stories.@(js|jsx|ts|tsx)'], + stories: [ + '../packages/**/chromatic/**/*.stories.@(js|jsx|ts|tsx)', + '../packages/@react-spectrum/s2/stories/*.stories.@(js|jsx|mjs|ts|tsx)' + ], addons: process.env.NODE_ENV === 'production' ? [] : [ '@storybook/addon-actions', '@storybook/addon-a11y' diff --git a/packages/@react-spectrum/s2/stories/Checkbox.stories.tsx b/packages/@react-spectrum/s2/stories/Checkbox.stories.tsx index 41b25e1d415..2c5c118490f 100644 --- a/packages/@react-spectrum/s2/stories/Checkbox.stories.tsx +++ b/packages/@react-spectrum/s2/stories/Checkbox.stories.tsx @@ -30,4 +30,4 @@ export default meta; export const Example = (args: any) => (Unsubscribe); -export const LongLabel = (args: any) => (Checkbox with very long label so we can see wrapping); +export const LongLabelS2 = (args: any) => (Checkbox with very long label so we can see wrapping); diff --git a/packages/@react-spectrum/s2/stories/SearchField.stories.tsx b/packages/@react-spectrum/s2/stories/SearchField.stories.tsx index a46fbeb293d..daa59909c58 100644 --- a/packages/@react-spectrum/s2/stories/SearchField.stories.tsx +++ b/packages/@react-spectrum/s2/stories/SearchField.stories.tsx @@ -42,18 +42,17 @@ Example.args = { label: 'Search' }; -export const CustomWidth = (args: any) => ; +export const CustomWidthS2 = (args: any) => ; -CustomWidth.args = { +CustomWidthS2.args = { label: 'Search' }; -CustomWidth.parameters = { +CustomWidthS2.parameters = { docs: { disable: true } }; - export const ContextualHelpExample = (args: any) => ; ContextualHelpExample.args = { diff --git a/packages/@react-spectrum/s2/stories/Slider.stories.tsx b/packages/@react-spectrum/s2/stories/Slider.stories.tsx index 544043a242f..887ee92f759 100644 --- a/packages/@react-spectrum/s2/stories/Slider.stories.tsx +++ b/packages/@react-spectrum/s2/stories/Slider.stories.tsx @@ -42,13 +42,13 @@ Example.args = { defaultValue: 30 }; -export const FillOffset = (args: any) => ( +export const FillOffsetS2 = (args: any) => (
); -FillOffset.args = { +FillOffsetS2.args = { label: 'Exposure', fillOffset: 0, defaultValue: 1.83, diff --git a/packages/@react-spectrum/s2/stories/Switch.stories.tsx b/packages/@react-spectrum/s2/stories/Switch.stories.tsx index 73455554e21..cba6c8aca77 100644 --- a/packages/@react-spectrum/s2/stories/Switch.stories.tsx +++ b/packages/@react-spectrum/s2/stories/Switch.stories.tsx @@ -30,4 +30,4 @@ export default meta; export const Example = (args: any) => Wi-Fi; -export const LongLabel = (args: any) => (Switch with very long label so we can see wrapping); +export const LongLabelS2 = (args: any) => (Switch with very long label so we can see wrapping); diff --git a/packages/@react-spectrum/s2/stories/TextField.stories.tsx b/packages/@react-spectrum/s2/stories/TextField.stories.tsx index 0fbe9e81352..ceb483885f3 100644 --- a/packages/@react-spectrum/s2/stories/TextField.stories.tsx +++ b/packages/@react-spectrum/s2/stories/TextField.stories.tsx @@ -111,12 +111,12 @@ TextAreaExample.args = { label: 'Comment' }; -export const CustomWidth = (args: any) => ; +export const CustomWidthS2 = (args: any) => ; -CustomWidth.args = { +CustomWidthS2.args = { label: 'Name' }; -CustomWidth.parameters = { +CustomWidthS2.parameters = { docs: { disable: true } From 838482bace9f964f30f99eb9ecd7480b9c781605 Mon Sep 17 00:00:00 2001 From: Daniel Lu Date: Wed, 28 Aug 2024 11:22:11 -0700 Subject: [PATCH 02/12] Add variable font and update titles --- .chromatic/preview-head.html | 7 +++++++ packages/@react-spectrum/s2/stories/Checkbox.stories.tsx | 2 +- .../@react-spectrum/s2/stories/SearchField.stories.tsx | 6 +++--- packages/@react-spectrum/s2/stories/Slider.stories.tsx | 4 ++-- packages/@react-spectrum/s2/stories/Switch.stories.tsx | 2 +- packages/@react-spectrum/s2/stories/TextField.stories.tsx | 6 +++--- 6 files changed, 17 insertions(+), 10 deletions(-) diff --git a/.chromatic/preview-head.html b/.chromatic/preview-head.html index b55ba3dee9b..02e30d149e6 100644 --- a/.chromatic/preview-head.html +++ b/.chromatic/preview-head.html @@ -134,6 +134,13 @@ + + + + + + + +