Skip to content

Fix hero image urls #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2020
Merged

Fix hero image urls #724

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
953f27f
Fix hero image urls
devongovett Jul 10, 2020
1974204
lint
devongovett Jul 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions packages/dev/docs/src/Image.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
*/

import docStyles from './docs.css';
import path from 'path';
import React from 'react';

export const ImageContext = React.createContext();
Expand All @@ -19,14 +20,14 @@ export function Hero({wide, narrow, wide2x, narrow2x, wideWebp, narrowWebp, wide
// Temporary fix for parcel issue with relative urls in server rendering.
let publicUrl = React.useContext(ImageContext);
let baseUrl = publicUrl.replace(/\/$/, '');
let narrowUrl = baseUrl + narrow;
let narrow2xUrl = baseUrl + narrow2x;
let wideUrl = baseUrl + wide;
let wide2xUrl = baseUrl + wide2x;
let narrowWebpUrl = baseUrl + narrowWebp;
let narrow2xWebpUrl = baseUrl + narrow2xWebp;
let wideWebpUrl = baseUrl + wideWebp;
let wide2xWebpUrl = baseUrl + wide2xWebp;
let narrowUrl = baseUrl + '/' + path.basename(narrow);
let narrow2xUrl = baseUrl + '/' + path.basename(narrow2x);
let wideUrl = baseUrl + '/' + path.basename(wide);
let wide2xUrl = baseUrl + '/' + path.basename(wide2x);
let narrowWebpUrl = baseUrl + '/' + path.basename(narrowWebp);
let narrow2xWebpUrl = baseUrl + '/' + path.basename(narrow2xWebp);
let wideWebpUrl = baseUrl + '/' + path.basename(wideWebp);
let wide2xWebpUrl = baseUrl + '/' + path.basename(wide2xWebp);

return (
<div className={docStyles.heroImage}>
Expand Down