Skip to content

fix: documentation select placeholder default #7941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 12, 2025
Merged

fix: documentation select placeholder default #7941

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5427c1c
fix: documentation select placeholder default
snowystinger Mar 17, 2025
0222957
Merge branch 'main' into default-select-placeholder
snowystinger Mar 17, 2025
e2ac78f
Update packages/react-aria-components/src/Select.tsx
snowystinger Mar 17, 2025
c2faf4a
update description
LFDanLu Apr 12, 2025
6c7a89b
Merge branch 'main' into default-select-placeholder
devongovett Apr 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/react-aria-components/src/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,13 @@ export interface SelectRenderProps {
isRequired: boolean
}

export interface SelectProps<T extends object = {}> extends Omit<AriaSelectProps<T>, 'children' | 'label' | 'description' | 'errorMessage' | 'validationState' | 'validationBehavior' | 'items'>, RACValidation, RenderProps<SelectRenderProps>, SlotProps {}
export interface SelectProps<T extends object = {}> extends Omit<AriaSelectProps<T>, 'children' | 'label' | 'description' | 'errorMessage' | 'validationState' | 'validationBehavior' | 'items'>, RACValidation, RenderProps<SelectRenderProps>, SlotProps {
/**
* Temporary text that occupies the select when it is empty.
* @default 'Select an item' (localized)
*/
placeholder?: string
}

export const SelectContext = createContext<ContextValue<SelectProps<any>, HTMLDivElement>>(null);
export const SelectStateContext = createContext<SelectState<unknown> | null>(null);
Expand Down