Skip to content

chore: change peer dep for S2 to be React 19 only #9211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2025
+13 −11
Merged

chore: change peer dep for S2 to be React 19 only #9211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8eeca22
chore: change peer dep for S2 to be 19 only
LFDanLu Nov 18, 2025
dbbb7d6
forgot to change lock
LFDanLu Nov 18, 2025
83f2d21
fix lint
LFDanLu Nov 18, 2025
7ed0985
update the icon builder as well
LFDanLu Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@react-spectrum/s2/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,8 @@
"react-stately": "^3.42.0"
},
"peerDependencies": {
"react": "^18.0.0 || ^19.0.0-rc.1",
"react-dom": "^18.0.0 || ^19.0.0-rc.1"
"react": "^19.0.0-rc.1",
"react-dom": "^19.0.0-rc.1"
},
"publishConfig": {
"access": "public"
Expand Down
4 changes: 2 additions & 2 deletions packages/dev/s2-icon-builder/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
},
"peerDependencies": {
"@react-spectrum/s2": ">=0.8.0",
"react": "^18.0.0 || ^19.0.0-rc.1",
"react-dom": "^18.0.0 || ^19.0.0-rc.1"
"react": "^19.0.0-rc.1",
"react-dom": "^19.0.0-rc.1"
},
"files": [
"index.js",
Expand Down
4 changes: 2 additions & 2 deletions scripts/verdaccio-build-icon-builder.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ cat > icon-library-test/package.json << EOF
},
"peerDependencies": {
"@react-spectrum/s2": ">=0.8.0",
"react": "^18.0.0 || ^19.0.0-rc.1",
"react-dom": "^18.0.0 || ^19.0.0-rc.1"
"react": "^19.0.0-rc.1",
"react-dom": "^19.0.0-rc.1"
},
"devDependencies": {
"@react-spectrum/s2-icon-builder": "latest",
Expand Down
4 changes: 3 additions & 1 deletion yarn.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ function enforceConsistentDependenciesAcrossTheProject({Yarn}) {
}
if (dependency.workspace.ident === 'storybook-builder-parcel') {
dependency.update('*');
} else if (dependency.workspace.ident === '@react-spectrum/s2' || dependency.workspace.ident === '@react-spectrum/codemods' || dependency.workspace.ident === '@react-spectrum/s2-icon-builder') {
} else if (dependency.workspace.ident === '@react-spectrum/s2' || dependency.workspace.ident === '@react-spectrum/s2-icon-builder') {
dependency.update('^19.0.0-rc.1');
} else if (dependency.workspace.ident === '@react-spectrum/codemods') {
dependency.update('^18.0.0 || ^19.0.0-rc.1');
Comment on lines +26 to 29
Copy link
Member Author

@LFDanLu LFDanLu Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct since the codemods also include v3 specific monopackage codemods?

} else {
dependency.update('^16.8.0 || ^17.0.0-rc.1 || ^18.0.0 || ^19.0.0-rc.1');
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7525,8 +7525,8 @@ __metadata:
glob: "npm:^11.0.3"
peerDependencies:
"@react-spectrum/s2": ">=0.8.0"
react: ^18.0.0 || ^19.0.0-rc.1
react-dom: ^18.0.0 || ^19.0.0-rc.1
react: ^19.0.0-rc.1
react-dom: ^19.0.0-rc.1
bin:
transform-icons: index.js
languageName: unknown
Expand Down Expand Up @@ -7567,8 +7567,8 @@ __metadata:
react-aria-components: "npm:^1.13.0"
react-stately: "npm:^3.42.0"
peerDependencies:
react: ^18.0.0 || ^19.0.0-rc.1
react-dom: ^18.0.0 || ^19.0.0-rc.1
react: ^19.0.0-rc.1
react-dom: ^19.0.0-rc.1
languageName: unknown
linkType: soft

Expand Down