Skip to content

Conversation

@yihuiliao
Copy link
Member

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@yihuiliao yihuiliao changed the title docs: S2 separator docs docs: React Aria separator docs Dec 5, 2025
@rspbot
Copy link

rspbot commented Dec 5, 2025

@dannify
Copy link
Member

dannify commented Dec 5, 2025

Is this meant to be at the bottom?
image

@yihuiliao
Copy link
Member Author

yihuiliao commented Dec 5, 2025

@dannify Yup, there's no render props so the last thing that should appear is the default classname. Other doc pages are like this too

@rspbot
Copy link

rspbot commented Dec 5, 2025

@rspbot
Copy link

rspbot commented Dec 5, 2025

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dannify i agree, it's a little hard to find the default class name, especially in other pages where it's sandwiched between two prop tables, it's so small. We should make it a little more prominent across the board I think.

@yihuiliao yihuiliao added this pull request to the merge queue Dec 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2025
@LFDanLu LFDanLu added this pull request to the merge queue Dec 6, 2025
Merged via the queue into main with commit f0d808e Dec 6, 2025
33 checks passed
@LFDanLu LFDanLu deleted the s2-separator-docs branch December 6, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants