ListLayout cache invalidation fixes #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
|
Build successful! 🎉 |
devongovett
commented
Aug 12, 2020
Thank you! <3 Co-authored-by: Devon Govett <devongovett@gmail.com>
snowystinger
approved these changes
Aug 12, 2020
|
Build successful! 🎉 |
dannify
approved these changes
Aug 12, 2020
LFDanLu
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues with cache invalidation in ListLayout.
nodeas part of theLayoutNodeand comparing the cached node vs the current node, rather than storing a separate map.AlayoutInfoToStylewas not invalidating because we mutated LayoutInfo objects, and also because it depends on the parent layoutInfo as well to compute the absolute position. This is now checked before reusing the cached value.