feat: read daily brand presence files for llmo #1407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a minor release when merged. |
Comment on lines
+116
to
+122
| if (sheetType && week) { | ||
| sheetURL = `${llmoConfig.dataFolder}/${sheetType}/${week}/${dataSource}.json`; | ||
| } else if (sheetType) { | ||
| sheetURL = `${llmoConfig.dataFolder}/${sheetType}/${dataSource}.json`; | ||
| } else { | ||
| sheetURL = `${llmoConfig.dataFolder}/${dataSource}.json`; | ||
| } |
There was a problem hiding this comment.
Shall we add validation here for the pattern mentioned at https://github.com/adobe/spacecat-api-service/pull/1407/files#diff-ae9e8d5c98f43812db0a4be0f048072a936f12cf64194979387ec5c56908c17fR164
rachel-kittens
approved these changes
Oct 29, 2025
vivesing
approved these changes
Oct 29, 2025
solaris007
pushed a commit
that referenced
this pull request
Oct 29, 2025
# [1.216.0](v1.215.1...v1.216.0) (2025-10-29) ### Features * read daily brand presence files for llmo ([#1407](#1407)) ([66de1a1](66de1a1))
|
🎉 This PR is included in version 1.216.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
JayKid
added a commit
that referenced
this pull request
Oct 29, 2025
…-categories-LLMO-845 * main: chore(release): 1.216.0 [skip ci] feat: read daily brand presence files for llmo (#1407) chore(release): 1.215.1 [skip ci] fix(deps): update adobe fixes (#1409) chore(release): 1.215.0 [skip ci] feat: added paged suggestion function (#1403) chore(release): 1.214.9 [skip ci] fix: Enable addition of Private Repos in Spacecat via Slack and add s… (#1373) chore(release): 1.214.8 [skip ci] fix(deps): update adobe fixes (#1406) chore(release): 1.214.7 [skip ci] fix(deps): update adobe fixes (#1405)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.