Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accordion): simplify header sizing, remove unmanaged custom property #1041

Closed
wants to merge 1 commit into from

Conversation

Westbrook
Copy link
Contributor

Description

fixes #1033

  • simplify calculation of the Accordion heading to rely on %s rather than --spectrum-accordion-item-height-actual
  • remove use of --spectrum-accordion-item-height-actual custom property (which was unmanaged across various scales)

How and where has this been tested?

Screenshots

image
image

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@Westbrook
Copy link
Contributor Author

This looks like it's failing the visual regression internal to the CI. It's not clear in the output there if it's just my one pattern, as expected, or not. Is there anything I can/need to do about that being I expect there to be one pattern with failure(s) here?

@Westbrook
Copy link
Contributor Author

closing in preference of #1048

@Westbrook Westbrook closed this Oct 8, 2020
@Westbrook Westbrook deleted the westbrook/accordion branch October 8, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Accordion] Item hight not using a controlled CSS Custom Property
1 participant