From 39d0b62f8e8bd7f55b2871f21ec0376e688bf7d8 Mon Sep 17 00:00:00 2001 From: Marissa Huysentruyt Date: Mon, 29 Jul 2024 11:02:37 -0400 Subject: [PATCH 1/4] fix(meter): override positive/negative/notice fills for static white --- components/progressbar/index.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/progressbar/index.css b/components/progressbar/index.css index ef7f77e9f8..9402114323 100644 --- a/components/progressbar/index.css +++ b/components/progressbar/index.css @@ -223,7 +223,7 @@ } /* Static White */ -.spectrum-ProgressBar--staticWhite { +.spectrum-ProgressBar.spectrum-ProgressBar--staticWhite { .spectrum-ProgressBar-fill { color: var(--mod-progressbar-label-and-value-white, var(--spectrum-progressbar-label-and-value-white)); background-color: var(--mod-progressbar-fill-color-white, var(--spectrum-progressbar-fill-color-white)); From ab72589d5fcd1397a2e2c95b77b57cd5a7689479 Mon Sep 17 00:00:00 2001 From: Marissa Huysentruyt Date: Mon, 29 Jul 2024 11:14:03 -0400 Subject: [PATCH 2/4] feat(meter): add static white story --- components/progressbar/stories/meter.stories.js | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/components/progressbar/stories/meter.stories.js b/components/progressbar/stories/meter.stories.js index f4a528279c..a9b8e22172 100644 --- a/components/progressbar/stories/meter.stories.js +++ b/components/progressbar/stories/meter.stories.js @@ -45,3 +45,16 @@ WithForcedColors.parameters = { modes: disableDefaultModes }, }; + +export const StaticWhite = Default.bind({}); +StaticWhite.tags = ["!autodocs", "!dev", "test"]; +StaticWhite.args = { + staticColor: "white", + label: "Loading your fonts, images, and icons", + value: 50, +}; +StaticWhite.parameters = { + chromatic: { + modes: disableDefaultModes + }, +}; From ce17250dd6b02832470f864e5e3981ccef09b565 Mon Sep 17 00:00:00 2001 From: Marissa Huysentruyt Date: Tue, 6 Aug 2024 12:53:06 -0400 Subject: [PATCH 3/4] chore(meter): changeset --- .changeset/lucky-jeans-happen.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/lucky-jeans-happen.md diff --git a/.changeset/lucky-jeans-happen.md b/.changeset/lucky-jeans-happen.md new file mode 100644 index 0000000000..202c0df0dc --- /dev/null +++ b/.changeset/lucky-jeans-happen.md @@ -0,0 +1,6 @@ +--- +"@spectrum-css/progressbar": patch +--- + +- Enforces the correct static white progress bar fill color when meter is using both the `spectrum-ProgressBar--staticWhite` class and one of the `is-positive`, `is-negative`, or `is-notice` classes. +- Adds a static white story to meter. From e41ba19127263354d5b8c2f2cfd51abb2348a2d2 Mon Sep 17 00:00:00 2001 From: Marissa Huysentruyt Date: Fri, 9 Aug 2024 13:17:53 -0400 Subject: [PATCH 4/4] fix(meter): remove test tag --- components/progressbar/stories/meter.stories.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/progressbar/stories/meter.stories.js b/components/progressbar/stories/meter.stories.js index a9b8e22172..2c78873b6f 100644 --- a/components/progressbar/stories/meter.stories.js +++ b/components/progressbar/stories/meter.stories.js @@ -47,7 +47,7 @@ WithForcedColors.parameters = { }; export const StaticWhite = Default.bind({}); -StaticWhite.tags = ["!autodocs", "!dev", "test"]; +StaticWhite.tags = ["!autodocs", "!dev"]; StaticWhite.args = { staticColor: "white", label: "Loading your fonts, images, and icons",