From 6e3ef36e8f423f08c2537eb2d075bec4118f2e86 Mon Sep 17 00:00:00 2001 From: Piyush Vashisht Date: Thu, 27 Jul 2023 22:46:14 +0530 Subject: [PATCH] fix(tags): performed the suggested changes --- packages/tags/src/Tags.ts | 1 + tools/reactive-controllers/src/FocusGroup.ts | 9 +++------ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/tags/src/Tags.ts b/packages/tags/src/Tags.ts index 59982aa5db..95ebb3aa63 100644 --- a/packages/tags/src/Tags.ts +++ b/packages/tags/src/Tags.ts @@ -70,6 +70,7 @@ export class Tags extends FocusVisiblePolyfillMixin(SpectrumElement) { private handleKeydown = (event: KeyboardEvent): void => { const { code } = event; if (code !== 'PageUp' && code !== 'PageDown') return; + const circularIndexedElement = ( list: T[], index: number diff --git a/tools/reactive-controllers/src/FocusGroup.ts b/tools/reactive-controllers/src/FocusGroup.ts index f7edffd82b..30a51548b4 100644 --- a/tools/reactive-controllers/src/FocusGroup.ts +++ b/tools/reactive-controllers/src/FocusGroup.ts @@ -130,7 +130,7 @@ export class FocusGroupController subtree: true, }, callback: () => { - this.changeDefaultItemFocus(); + this.handleItemMutation(); }, }); this.host = host; @@ -155,12 +155,9 @@ export class FocusGroupController ); } - changeDefaultItemFocus(): void { + handleItemMutation(): void { this.clearElementCache(); - let diff = 0; - if (this.currentIndex === this.elements.length) { - diff = -1; - } + const diff = this.currentIndex === this.elements.length ? -1 : 0; this.setCurrentIndexCircularly(diff); let steps = this.elements.length; while (