From 9f10bdf68eca661775fea69cc9d07e4e4cfb37b8 Mon Sep 17 00:00:00 2001 From: Rajdeep Chandra Date: Tue, 14 Nov 2023 20:02:14 +0530 Subject: [PATCH 1/2] docs(split-view): added label for resizable examples for documentation --- packages/split-view/README.md | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/packages/split-view/README.md b/packages/split-view/README.md index 26bdc33aa8e..70b92c0cba7 100644 --- a/packages/split-view/README.md +++ b/packages/split-view/README.md @@ -38,7 +38,13 @@ import { SplitView } from '@spectrum-web-components/split-view'; ### Horizontal Resizable ```html - +

Left panel

@@ -59,7 +65,7 @@ import { SplitView } from '@spectrum-web-components/split-view'; ### Horizontal Resizable & Collapsible ```html - +

Left panel

@@ -95,6 +101,7 @@ import { SplitView } from '@spectrum-web-components/split-view'; primary-min="50" primary-max="150" secondary-min="50" + label >

Top panel

@@ -116,7 +123,7 @@ import { SplitView } from '@spectrum-web-components/split-view'; ### Vertical Resizable & Collapsible ```html - +

Top panel

From 369fdcc4f62b1081d11446be5899496be5c820f4 Mon Sep 17 00:00:00 2001 From: Rajdeep Chandra Date: Thu, 30 Nov 2023 17:10:44 +0530 Subject: [PATCH 2/2] chore(split-view): updated readme and label logic --- packages/split-view/README.md | 13 +++++++++---- packages/split-view/src/SplitView.ts | 2 +- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/packages/split-view/README.md b/packages/split-view/README.md index 70b92c0cba7..51a5339a811 100644 --- a/packages/split-view/README.md +++ b/packages/split-view/README.md @@ -43,7 +43,7 @@ import { SplitView } from '@spectrum-web-components/split-view'; primary-min="50" secondary-min="50" primary-size="100" - label + label="Resize the horizontal panels" >

Left panel

@@ -65,7 +65,7 @@ import { SplitView } from '@spectrum-web-components/split-view'; ### Horizontal Resizable & Collapsible ```html - +

Left panel

@@ -101,7 +101,7 @@ import { SplitView } from '@spectrum-web-components/split-view'; primary-min="50" primary-max="150" secondary-min="50" - label + label="Resize the vertical panels" >

Top panel

@@ -123,7 +123,12 @@ import { SplitView } from '@spectrum-web-components/split-view'; ### Vertical Resizable & Collapsible ```html - +

Top panel

diff --git a/packages/split-view/src/SplitView.ts b/packages/split-view/src/SplitView.ts index 9214c23c8e1..a2c3997957b 100644 --- a/packages/split-view/src/SplitView.ts +++ b/packages/split-view/src/SplitView.ts @@ -184,7 +184,7 @@ export class SplitView extends SpectrumElement { )) as boolean, }; const label = - this.label || this.resizable ? 'Resize the panels' : undefined; + this.label || (this.resizable ? 'Resize the panels' : undefined); return html`