-
Notifications
You must be signed in to change notification settings - Fork 236
chore(picker): update css version to latest foundations #5087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
846d603 to
173da8e
Compare
173da8e to
cd076bf
Compare
Pull Request Test Coverage Report for Build 13287783943Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
* chore(picker): update css version to latest foundations * chore: update golden images cache
…d menu to latest foundations (#5068) * chore: update actionbutton, ui-icons, tokens, button to latest * chore: update vrts retry to one * chore(icon): add overflow hidden if icon is not root * chore: update menu popover to support action menu * chore(button): update config to support updated css structure * chore: updated spectrum config actionbutton * chore: update spectrumconfig actiongroup * chore(action-group): add correct css for justified state * chore(button): update to latest tag * chore(picker): update css version to latest foundations (#5087) * chore(picker): update css version to latest foundations * chore: update golden images cache * chore: release new versions #publish * chore: fix stale lockfile #publish (#5091) * chore: update button and tokens to latest main * chore: update actionbutton to latest css * chore: try increasing timeout for netlify deploy * chore: nit picks * chore: update golden image hash * chore: update golden image hash * chore: updated golden image hash --------- Co-authored-by: Rúben Carvalho <rubcar@sapo.pt> Co-authored-by: Rajdeep Chandra <rajdeepchandra@Rajdeeps-MacBook-Pro-2.local> Co-authored-by: Rajdeep Chandra <rajrock38@gmail.com>
* chore(picker): update css version to latest foundations * chore: update golden images cache
…d menu to latest foundations (#5068) * chore: update actionbutton, ui-icons, tokens, button to latest * chore: update vrts retry to one * chore(icon): add overflow hidden if icon is not root * chore: update menu popover to support action menu * chore(button): update config to support updated css structure * chore: updated spectrum config actionbutton * chore: update spectrumconfig actiongroup * chore(action-group): add correct css for justified state * chore(button): update to latest tag * chore(picker): update css version to latest foundations (#5087) * chore(picker): update css version to latest foundations * chore: update golden images cache * chore: release new versions #publish * chore: fix stale lockfile #publish (#5091) * chore: update button and tokens to latest main * chore: update actionbutton to latest css * chore: try increasing timeout for netlify deploy * chore: nit picks * chore: update golden image hash * chore: update golden image hash * chore: updated golden image hash --------- Co-authored-by: Rúben Carvalho <rubcar@sapo.pt> Co-authored-by: Rajdeep Chandra <rajdeepchandra@Rajdeeps-MacBook-Pro-2.local> Co-authored-by: Rajdeep Chandra <rajrock38@gmail.com>
…d menu to latest foundations (#5068) * chore: update actionbutton, ui-icons, tokens, button to latest * chore: update vrts retry to one * chore(icon): add overflow hidden if icon is not root * chore: update menu popover to support action menu * chore(button): update config to support updated css structure * chore: updated spectrum config actionbutton * chore: update spectrumconfig actiongroup * chore(action-group): add correct css for justified state * chore(button): update to latest tag * chore(picker): update css version to latest foundations (#5087) * chore(picker): update css version to latest foundations * chore: update golden images cache * chore: release new versions #publish * chore: fix stale lockfile #publish (#5091) * chore: update button and tokens to latest main * chore: update actionbutton to latest css * chore: try increasing timeout for netlify deploy * chore: nit picks * chore: update golden image hash * chore: update golden image hash * chore: updated golden image hash --------- Co-authored-by: Rúben Carvalho <rubcar@sapo.pt> Co-authored-by: Rajdeep Chandra <rajdeepchandra@Rajdeeps-MacBook-Pro-2.local> Co-authored-by: Rajdeep Chandra <rajrock38@gmail.com>
Description
Bumping the "Picker" component to the latest CSS version, to get up to date with the latest Spectrum 2 designs.
Related issue(s)
Motivation and context
After the recent release of Spectrum 2 (foundations), we want to keep updating our components to the latest design specs.
How has this been tested?
All changes manually validated against the CSS implementation.
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.