Update media.schema.json#1643
Merged
Merged
Conversation
psnep
reviewed
Oct 19, 2022
| "title": "Video segment", | ||
| "type": "string", | ||
| "pattern": "^[[0-9]+-[0-9]+]$", | ||
| "pattern": "^[0-9]+-[0-9]+$", |
There was a problem hiding this comment.
From our previous experience it won't work regardless of the pattern until the pattern is not removed. At some point as a test I created a field with a very simple pattern(to contain a digit) at that one didn't work either. So I presumed that it is a general problem regarding the pattern property of a field and it is not working as expected.
hanessian
requested changes
Oct 19, 2022
Collaborator
hanessian
left a comment
hanessian
left a comment
There was a problem hiding this comment.
Are any customers using the configuration of the old pattern? If so, then this will be be a breaking change. If not, we can go through with the change. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix the bug that is introduced due to the change in pattern for video segment property