Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert person-name from given/sur(name) back to first/last(name) for industry compatibility #215

Merged
merged 4 commits into from
Apr 5, 2018

Conversation

kstreeter
Copy link
Collaborator

Please link to the issue #…
PR for Issue #177

@lrosenthol
Copy link
Collaborator

Looks good to me - thanks @kstreeter

@cdegroot-adobe
Copy link
Contributor

@kstreeter yes, this works very well for me. I approve.

Copy link
Contributor

@trieloff trieloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like the idea #177 not being a good one in the first place, I think this implementation is flawed, because it is simply renaming the properties, but not changing the semantics.

The original semantics are more meaningful, but having the correct semantics with the wrong name is only making this more confusing.

I realize that there seems to be a solid majority among the editors to make this change, and I will cede, but not without pointing out that this is making things harder to explain and harder for international use.

@@ -36,7 +36,7 @@
"description":
"Normally an abbreviation of a persons *title*, *honorific*, or *salutation*.\nThe `courtesyTitle` is used in front of full or last name in opening texts.\ne.g Mr. Miss. or Dr J. Smith.\n"
},
"xdm:name": {
"xdm:fullName": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use xdm:name for the proper name in other places, I don't see reason to deviate here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trieloff So what would you put in "name" a persons preferred name or their legal(called when in trouble or by ones mother) name.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like "fullName" makes it clearer what should go in here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdegroot-adobe I'd put in:

The full name of the person, in writing order most commonly accepted in the language of the name.

Exactly as the description says. I think the title="Full Name" makes things clear enough and makes things more consistent as we don't have *name properties elsewhere. fullName is a special case that in my mind does not have enough justification. (Using the full name in the name property is something I absolutely support)

"xdm:surname": {
"title": "Surname",
"xdm:lastName": {
"title": "Last name",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so this is just a title replacement? I think it is making it even more confusing. Now what is labeled lastName is indeed a "surname" and should be treated like one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trieloff - the point of this set of changes is quite well thought out considering the complex issues. The generally agreed best principles going forward in person naming is that there is no correct way to separate person name components and that it specifically should be avoided. Hence "fullName" which is inline with these recommendations. The current overwhelming standard in the industry due to legacy RDBMS and data principles has been to have a first/last name. So that is something we cannot ignore. give/sur name actually are significant issues in their own right and just introduce a different version of first/last name problem with unique new semantics in non western cultures.

So the root proposal is:
a) we have a longer term correct approach with "fullName" that is more commonly being used in parallel with separated name component semantics.
b) we retain the current standard in data which is first/last name

I continue to agree with this proposal. and the interoperability it provides.

It will be interesting to see if implementation start to use "legalName", which I expect they will in some industries, and that is specifically a reason I am avoiding the "name" usage. It is very common to have a different legalName, fullName and firstName+{space}+lastName, I am an example of that. And the caucasian person who sits beside me has an issues where his firstName != givenName.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to improve the descriptions.
I propose:
"The preferred first name of the person."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on @cdegroot-adobe description of the rationale. This is not intended to be a choice of first/last versus given/surname. We are saying that the preference is to use the full name (which is inline with the recommendations from W3C, and compatible with schema.org), but because our own applications and many applications in the industry use first/last we provide those fields to allow a direct translation.

@@ -36,7 +36,7 @@
"description":
"Normally an abbreviation of a persons *title*, *honorific*, or *salutation*.\nThe `courtesyTitle` is used in front of full or last name in opening texts.\ne.g Mr. Miss. or Dr J. Smith.\n"
},
"xdm:name": {
"xdm:fullName": {
"title": "Full name",
"type": "string",
"description":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to improve the descriptions.
I propose:
"The preferred last name of the person."

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdegroot-adobe I think you meant to make this comment on xdm:lastName, not xdm:fullName.

@kstreeter
Copy link
Collaborator Author

kstreeter commented Apr 5, 2018

It looks like we will need some further discussion on @trieloff 's proposal to include both first/last and given/surname fields, and a methodology on how to use them. In the mean time, I think we have consensus that the current fields (firstName, lastName, fullName) are appropriate, so I am merging this in preparation for the 0.9 milestone.

I filed issue #277 to track the proposed additions.

@kstreeter kstreeter merged commit 18708b0 into master Apr 5, 2018
trieloff added a commit that referenced this pull request Apr 10, 2018
Update Names to Reflect Discussions from #177 and #215
@cmathis cmathis deleted the platform-pr-personname branch February 20, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants