[MWPW-193816] skip file dimension check if not able to get width/height of image#780
Conversation
| try { | ||
| ({ width, height } = await getImageDimensions(file)); | ||
| } catch (e) { | ||
| window.lana?.log(`Message: Skipping image dimension check (unreadable), Error: ${e}`, this.lanaOptions); |
There was a problem hiding this comment.
Please remove lana log for client side errors.
There was a problem hiding this comment.
Is this logic tested? getImageDimensions() throws an error if the filetupe cannot be determined. I believe if dimensions are not present it may not throw error. Can you check this.?
There was a problem hiding this comment.
@arugupta1992 @sanjayms01
even if the fileType is determined and if we are not able to extract the dimensions, it throws an exception which we are not catching and leading to block the user to redirect to FF without giving any proper error message.
We should anyways redirect the user to FF if we are not able to get the dimensions.
wrt to the lana logs, we are not sending any analytics in this case, so I believe we can have the lana log.
|
Validation done in the branch. All looks fine. Test results are in the task: MWPW-195836 |
…ht of image (#780) skip file dimension check if not able to get width/height of image please check the slack thread for asset details: https://adobe-mwp.slack.com/archives/C0AE5AP6Q9L/p1778625759895929 Resolves: [MWPW-193816](https://jira.corp.adobe.com/browse/MWPW-193816) **Test URLs:** - Before: https://main--da-cc--adobecom.aem.page/products/firefly/features/ai-image-expander - After: https://main--da-cc--adobecom.aem.page/products/firefly/features/ai-image-expander?unitylibs=mwpw-193816 --------- Co-authored-by: vipulg <vipulg@adobe.com> (cherry picked from commit d95a8b6)
5 participants
skip file dimension check if not able to get width/height of image
please check the slack thread for asset details:
https://adobe-mwp.slack.com/archives/C0AE5AP6Q9L/p1778625759895929
Resolves: MWPW-193816
Test URLs: