Skip to content

Resolving code issues seen in analytics #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arugupta1992 merged 2 commits into from
May 20, 2026
Merged

Resolving code issues seen in analytics #781

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4298629
resolving code issues seen in analytics
May 18, 2026
b610d3b
Merge branch 'stage' into videoanalyticsIssue
arugupta1992 May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions unitylibs/core/workflow/workflow-prompt-bar-upload/action-binder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,11 @@ export default class ActionBinder {
}
}

logAnalytics(eventName, data) {
logAnalyticsinSplunk(eventName, data = {}) {
this.sendAnalyticsToSplunk?.(
eventName,
this.workflowCfg.productName,
{ ...data,
{ ...data,
operation: this.verb,
action: 'upload-generate' },
`${unityConfig.apiEndPoint}/log`,
Expand Down Expand Up @@ -225,7 +225,7 @@ export default class ActionBinder {
this.lanaOptions,
'client',
);
this.logAnalytics('Upload client error|UnityWidget', { errorData: { code: errorCode }, fileMetaData: this.filesData });
this.logAnalyticsinSplunk('Upload client error|UnityWidget', { errorData: { code: errorCode }, fileMetaData: this.filesData });
}

setSelectSpinnerVisible(visible) {
Expand Down Expand Up @@ -306,7 +306,7 @@ export default class ActionBinder {
if (signal.aborted) return false;
const { id, href, blocksize, uploadUrls } = resJson;
this.assetId = id;
this.logAnalytics('Asset Created|UnityWidget', { assetId: this.assetId });
this.logAnalyticsinSplunk('Asset Created|UnityWidget', { assetId: this.assetId });
const { default: UploadHandler } = await import(`${getUnityLibs()}/core/workflow/workflow-upload/upload-handler.js`);
const uploadHandler = new UploadHandler(this, this.serviceHandler);
if (blocksize && uploadUrls && Array.isArray(uploadUrls)) {
Expand All @@ -315,7 +315,7 @@ export default class ActionBinder {
if (signal.aborted) return false;
const error = new Error(`One or more chunks failed for asset: ${id}`);
error.status = 504;
this.logAnalytics('Chunked Upload Failed|UnityWidget', {
this.logAnalyticsinSplunk('Chunked Upload Failed|UnityWidget', {
assetId: this.assetId,
failedChunks: failedChunks.size,
maxRetryCount: Math.max(...Array.from(attemptMap.values())),
Expand All @@ -325,7 +325,7 @@ export default class ActionBinder {
await uploadHandler.scanImgForSafetyWithRetry(this.assetId, signal);
const { createChunkAnalyticsData } = await import(`${getUnityLibs()}/utils/chunkingUtils.js`);
const totalChunks = Math.ceil(file.size / blocksize);
this.logAnalytics(
this.logAnalyticsinSplunk(
'Chunked Upload Completed|UnityWidget',
createChunkAnalyticsData('Chunked Upload Completed|UnityWidget', {
assetId: this.assetId,
Expand All @@ -337,7 +337,7 @@ export default class ActionBinder {
} else {
await this.uploadImgToUnity(href, id, file, file.type, signal);
await uploadHandler.scanImgForSafetyWithRetry(this.assetId, signal);
this.logAnalytics('Upload Completed|UnityWidget', { assetId: this.assetId });
this.logAnalyticsinSplunk('Upload Completed|UnityWidget', { assetId: this.assetId });
}
return true;
} catch (e) {
Expand All @@ -346,7 +346,7 @@ export default class ActionBinder {
return false;
}
this.serviceHandler.showErrorToast({ errorToastEl: this.errorToastEl, errorType: '.icon-error-request' }, e, this.lanaOptions);
this.logAnalytics('Upload server error|UnityWidget', {
this.logAnalyticsinSplunk('Upload server error|UnityWidget', {
errorData: {
code: 'error-request',
subCode: `uploadAsset ${e.status}`,
Expand All @@ -372,7 +372,7 @@ export default class ActionBinder {
if (!this.analyticsModule) await this.initAnalytics();
const eventName = this.analyticsModule.PROMPT_BAR_EVENTS.UPLOAD_FILE_ATTEMPT;
sendAnalyticsEvent(new CustomEvent(eventName));
this.logAnalytics(eventName, { action: uploadMethod });
this.logAnalyticsinSplunk(eventName, { action: uploadMethod });
} catch (e) {
window.lana?.log(`Message: Upload file attempt analytics failed, Error: ${e}`, this.lanaOptions);
}
Expand Down Expand Up @@ -403,8 +403,8 @@ export default class ActionBinder {
sendAnalyticsEvent(new CustomEvent(ctaEventName));
if (selectedModelName) sendAnalyticsEvent(new CustomEvent(pbuEvents.generateModel(selectedModelName)));
if (selectedAspectRatio) sendAnalyticsEvent(new CustomEvent(pbuEvents.ratioSelect(selectedAspectRatio)));
this.logAnalytics(pbuEvents.UPLOAD_STARTED, { fileMetaData: this.filesData });
this.logAnalytics(ctaEventName, {
this.logAnalyticsinSplunk(pbuEvents.UPLOAD_STARTED, { fileMetaData: this.filesData });
this.logAnalyticsinSplunk(ctaEventName, {
...(selectedModelName && {
modelGenEventName: pbuEvents.generateModel(selectedModelName),
}),
Expand Down Expand Up @@ -477,7 +477,7 @@ export default class ActionBinder {
},
);
if (this.promiseStack.length > 0) return;
this.logAnalytics('Generate Complete|UnityWidget', { assetId: this.assetId });
this.logAnalyticsinSplunk('Generate Complete|UnityWidget', { assetId: this.assetId });
this.LOADER_LIMIT = 100;
if (this.transitionScreen?.splashScreenEl) {
this.transitionScreen.LOADER_LIMIT = 100;
Expand All @@ -488,7 +488,7 @@ export default class ActionBinder {
if (err.message === 'Operation termination requested.') return;
await this.transitionScreen?.showSplashScreen();
this.serviceHandler.showErrorToast({ errorToastEl: this.errorToastEl, errorType: '.icon-error-request' }, err, this.lanaOptions);
this.logAnalytics('Upload server error|UnityWidget', {
this.logAnalyticsinSplunk('Upload server error|UnityWidget', {
errorData: {
code: 'error-request',
subCode: `continueInApp ${err.status}`,
Expand Down Expand Up @@ -518,7 +518,7 @@ export default class ActionBinder {
this.uploadAbortController?.abort();
this.uploadAbortController = null;
sendAnalyticsEvent(new CustomEvent('Cancel|UnityWidget'));
this.logAnalytics('Cancel|UnityWidget', { assetId: this.assetId });
this.logAnalyticsinSplunk('Cancel|UnityWidget', { assetId: this.assetId });
this.assetId = null;
await this.ensureTransitionScreen();
await this.transitionScreen.showSplashScreen();
Expand Down Expand Up @@ -554,7 +554,7 @@ export default class ActionBinder {
this.preventDefault(e);
const extracted = this.extractFiles(e);
this.filesData = { count: extracted.length, size: extracted[0]?.size, type: extracted[0]?.type };
this.logAnalytics('Drag and drop|UnityWidget', { assetId: this.assetId, fileMetaData: this.filesData });
this.logAnalyticsinSplunk('Drag and drop|UnityWidget', { assetId: this.assetId, fileMetaData: this.filesData });
await this.executeActionMaps(actMap[key], extracted);
});
el.addEventListener('click', () => {
Expand All @@ -574,7 +574,7 @@ export default class ActionBinder {
el.addEventListener('change', async (e) => {
const extracted = this.extractFiles(e);
this.filesData = { count: extracted.length, size: extracted[0]?.size, type: extracted[0]?.type };
this.logAnalytics('Click Drag and drop|UnityWidget', { assetId: this.assetId, fileMetaData: this.filesData });
this.logAnalyticsinSplunk('Click Drag and drop|UnityWidget', { assetId: this.assetId, fileMetaData: this.filesData });
await this.executeActionMaps(actMap[key], extracted);
e.target.value = '';
});
Expand Down Expand Up @@ -748,7 +748,7 @@ export default class ActionBinder {
bindWidgetInteractionEvent(domEventName, analyticsEventName, action) {
this.widgetWrap?.addEventListener(domEventName, () => {
sendAnalyticsEvent(new CustomEvent(analyticsEventName));
this.logAnalytics(analyticsEventName, { action });
this.logAnalyticsinSplunk(analyticsEventName, { action });
});
}

Expand Down
Loading