From c7a0a287733516484b4ef2d08259617d8dc9bcfc Mon Sep 17 00:00:00 2001 From: Ruchika Sinha Date: Tue, 19 May 2026 14:23:37 -0700 Subject: [PATCH 1/2] don't await finalize --- .../workflow-acrobat/upload-handler.js | 40 ++----------------- 1 file changed, 3 insertions(+), 37 deletions(-) diff --git a/unitylibs/core/workflow/workflow-acrobat/upload-handler.js b/unitylibs/core/workflow/workflow-acrobat/upload-handler.js index ba04bef4..56b93bad 100644 --- a/unitylibs/core/workflow/workflow-acrobat/upload-handler.js +++ b/unitylibs/core/workflow/workflow-acrobat/upload-handler.js @@ -211,46 +211,12 @@ export default class UploadHandler { this.actionBinder.getAdditionalHeaders() || {}, { body: JSON.stringify(finalAssetData), signal }, ); - const finalizeJson = await this.networkUtils.fetchFromServiceWithRetry( + this.networkUtils.fetchFromServiceWithRetry( this.actionBinder.acrobatApiConfig.acrobatEndpoint.finalizeAsset, finalizeOpts, this.actionBinder.workflowCfg.targetCfg.fetchApiConfig.finalizeAsset, - ); - if (!finalizeJson || Object.keys(finalizeJson).length !== 0) { - if (this.actionBinder.MULTI_FILE) { - await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', 500, `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson || {})}`, false, true, { - code: 'upload_error_finalize_asset', - desc: `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson || {})}`, - }); - return false; - } - await this.showSplashScreen(); - await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', 500, `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson)}`, false, true, { - code: 'upload_error_finalize_asset', - desc: `Unexpected response from finalize call: ${assetData.id}, ${JSON.stringify(finalizeJson)}`, - }); - this.actionBinder.operations = []; - return false; - } - } catch (e) { - if (e.name === 'AbortError') return false; - if (this.actionBinder.MULTI_FILE) { - await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', e.status || 500, `Exception thrown when verifying content: ${e.message}, ${assetData.id}`, false, e.showError, { - code: 'upload_error_finalize_asset', - subCode: e.status, - desc: `Exception thrown when verifying content: ${e.message}, ${assetData.id}`, - }); - return false; - } - await this.showSplashScreen(); - await this.actionBinder.dispatchErrorToast('upload_error_finalize_asset', e.status || 500, `Exception thrown when verifying content: ${e.message}, ${assetData.id}`, false, e.showError, { - code: 'upload_error_finalize_asset', - subCode: e.status, - desc: `Exception thrown when verifying content: ${e.message}, ${assetData.id}`, - }); - this.actionBinder.operations = []; - return false; - } + ).catch(() => {}); + } catch (e) { /* fire-and-forget */ } return true; } From 2816de18e1c40a018acbd487ee06b90783558425 Mon Sep 17 00:00:00 2001 From: Ruchika Sinha Date: Tue, 19 May 2026 14:44:58 -0700 Subject: [PATCH 2/2] wip --- unitylibs/core/workflow/workflow-acrobat/upload-handler.js | 1 + 1 file changed, 1 insertion(+) diff --git a/unitylibs/core/workflow/workflow-acrobat/upload-handler.js b/unitylibs/core/workflow/workflow-acrobat/upload-handler.js index 56b93bad..638faaa9 100644 --- a/unitylibs/core/workflow/workflow-acrobat/upload-handler.js +++ b/unitylibs/core/workflow/workflow-acrobat/upload-handler.js @@ -211,6 +211,7 @@ export default class UploadHandler { this.actionBinder.getAdditionalHeaders() || {}, { body: JSON.stringify(finalAssetData), signal }, ); + finalizeOpts.keepalive = true; this.networkUtils.fetchFromServiceWithRetry( this.actionBinder.acrobatApiConfig.acrobatEndpoint.finalizeAsset, finalizeOpts,