Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbioRad 0.5.2 #388
Merged
bioRad 0.5.2 #388
Conversation
- Use @rdname, not @describeIn - Use @Seealso - [rcs()<-] won't make a correct link, but it's best to reference it as such anyway
- Start with parameter test - Remove any context() as it is not needed - Not done for bioRad, bioRad-deprecated, hooks, is.nan.data.frame - Not conform test for raster-input
Setup test files for all functions
- Use x instead of object parameter - Use Markdown - Combine print.pvol.Rd into summary.pvol.Rd - Update example
- Replace "Change or set" to "Set" - Reduce example - Inherit parameters - Don't use ... in warning message
This removes a bunch of superfluous tests for rcs()
Sd vvp threshold unit tests
- Did not make them bold
- output wasn't defined yet at point in function - vp should check length$data$height, not x$height - vp does not need to multiply by x$datetime
Correctly process row.names in as.data.frame + bring test to 100% by testing for vpts
This was referenced May 10, 2020
(Unnoticable changes in) figures not committed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
No description provided.