New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements and new example #29

Merged
merged 4 commits into from May 15, 2017

Conversation

Projects
None yet
2 participants
@anoymouserver
Contributor

anoymouserver commented May 14, 2017

  • JavaScript code is now linted with JavaScript Style Guide
  • moved documentation to markdown
  • added example6 with Bootstrap Design

anoymouserver added some commits May 9, 2017

unify and beautify code
add editorconfig
move documentation to markdown
- its easier to edit
- you will see the diff if some changes occur
update example5 to CDN, add example6 with Bootstrap design
(Bootstrap currently at v4.0.0-alpha.6)
@adolfintel

This comment has been minimized.

Owner

adolfintel commented May 14, 2017

Thanks man! Looks good ;) Doesn't break anything.
Before I merge it, I have a question to ask: what command did you use to minify it? You just said "better"

@anoymouserver

This comment has been minimized.

Contributor

anoymouserver commented May 15, 2017

I also used uglifyjs but for my first commit I failed while compressing and the file was twice as large..

@adolfintel

This comment has been minimized.

Owner

adolfintel commented May 15, 2017

Oh, ok. I'll merge this when I get back from work.
Thank you

@adolfintel adolfintel merged commit 3f06ab1 into adolfintel:master May 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment