Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key aliases rebased #69

Merged
merged 7 commits into from Jul 8, 2015

Conversation

Projects
None yet
2 participants
@jpmoral
Copy link
Contributor

jpmoral commented Jul 8, 2015

Please see #68 for discussion. I couldn't update that branch for some reason so I opened this one.

jpmoral added some commits Jul 4, 2015

WithReducer accepts aliases
aliases is a hash.  Keys are keys found in the context, values are
aliases for the keys. For example, given the following:

data = { foo: 'foo' }
aliases = { foo: :alias_for_foo }

context passed to the actions will be:

{ foo: 'foo', alias_for_foo: 'foo' }

See spec/organizer/with_reducer_spec.rb
Add `aliases` macro to Organizer
aliases is passed to WithReducer to make key aliases available to all
actions

See spec/organizer_key_aliases_spec.rb

@jpmoral jpmoral referenced this pull request Jul 8, 2015

Closed

Context key aliases #68

end
end
class FooAction

This comment has been minimized.

@adomokos

adomokos Jul 8, 2015

Owner

This still says FooAction.

This comment has been minimized.

@jpmoral

jpmoral Jul 8, 2015

Author Contributor

Lol. I'll fix it.

@adomokos

This comment has been minimized.

Copy link
Owner

adomokos commented Jul 8, 2015

This looks awesome! Thank you for it! ❤️

adomokos added a commit that referenced this pull request Jul 8, 2015

@adomokos adomokos merged commit 8cd82f0 into adomokos:master Jul 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jpmoral

This comment has been minimized.

Copy link
Contributor Author

jpmoral commented Jul 8, 2015

Thanks! LightService is awesome, we use it very heavily at work.

@jpmoral jpmoral deleted the jpmoral:key-aliases-rebased branch Jul 8, 2015

@adomokos

This comment has been minimized.

Copy link
Owner

adomokos commented Jul 8, 2015

That's awesome! Thank you for contributing!

I am considering giving a talk on it as it approaches 1.0. Would you be open to a brief conversation on how you guys are using it? I am thinking Skype or Hangout. I'd like to incorporate other folks' story into my talk. Cheers!

@jpmoral

This comment has been minimized.

Copy link
Contributor Author

jpmoral commented Jul 8, 2015

Sure. I'm also planning to write a blog post about contributing to open source and use this PR as an example.

@adomokos

This comment has been minimized.

Copy link
Owner

adomokos commented Jul 8, 2015

I love that. If there is a gem or OSS I heavily rely on, I always try to pay back by contributing to it. Even with just tiny bits like fixing documentation. We just need to pay it forward! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.