Wrong filename and class name when creating an email class with ace.

[gribbl]

Package version

9.2.1

Describe the bug

When using the node ace make:mail verify_email command, the file generated is as follows:

app
└── mails
    ├── ...
    └── verify_e_notification.ts

And the class name :

import { BaseMail } from '@adonisjs/mail'

export default class VerifyENotification extends BaseMail {
  // ...
}

The mailName generator deletes mail and mailer. Is this intentional?

Reproduction repo

No response

[Julien-R44]

I believe adding a removeSuffix('email') here should be enough :

application/src/generators.ts

Line 415 in 12258d0

.removeSuffix('mailer')

Can you create a PR and adding a test for that please?

[gribbl]

So if I get it right. If we want a verify_email_notification.ts file we would end up with a verify_notification.ts file instead?

[Julien-R44]

Yup
You can use the --intent parameter to set another suffix

[thetutlage]

I think the concern is that our normalizer is from mail from the word email and hence the file is left with e only. Is it correct @JeanCastellotti ?

[gribbl]

Yeah. If someone wants to name his file verify_email_intent.ts (like this example in the documentation) we end up with verify_e_intent.ts or with verify_intent.ts with the solution suggested above. But what if the user wants to keep the word email in the filename with the default intent? But, this isn't a huge issue, just rename it. 😁 I just wanted to point it out as I have used the ace command recently to generate mail classes.

[thetutlage]

Yeah, we should fix it

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.