Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add typesVersions map #399

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

simonihmig
Copy link
Contributor

To allow consumers who are still on "moduleResolution": "node" in their TS config (i.e. where TS does not use exports) to resolve the types correctly.

To allow consumers who are still on `"moduleResolution": "node"` in their TS config (i.e. where TS does not use `exports`) to resolve the types correctly.
@ArnaudWeyts
Copy link

ArnaudWeyts commented Feb 28, 2024

@gilest This would also fix an issue we are running into (#348), and shouldn't result in a breaking change I suppose, are there any plans to merge this?

@NullVoxPopuli NullVoxPopuli merged commit 5655f48 into adopted-ember-addons:master Feb 29, 2024
7 of 8 checks passed
@github-actions github-actions bot mentioned this pull request Feb 29, 2024
@simonihmig simonihmig deleted the typesversions branch February 29, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants