Evaluate attrs options hash #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offirgolan
changed the title
offirgolan
added a commit
that referenced
this pull request
Jun 27, 2016
* master: [Feature] Warning Validators (#226) Evaluate attrs options hash (#223) chore(package): update ember-try to version 0.2.4 (#221) Fix for data validator with format (#218) chore(package): update ember-cli to version 2.6.2 (#217) chore(package): update ember-cli-moment-shim to version 2.0.0 (#216) chore(package): update ember-cli-blanket to version 0.9.5 (#214) Add import for getOwner to README example (#215) # Conflicts: # addon/validations/result-collection.js # addon/validations/result.js # tests/integration/validations/factory-general-test.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The options hash (
model.get('validations.attrs.username.options')) is currently useless when a validator options is a function. This fixes that by having it contain the latest cached options.Resolves ember-bootstrap/ember-bootstrap-cp-validations#4