Update ember-cli to v4.4 and drop support for node v12 #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsmanuel
force-pushed
the
update-ember-cli-to-4-x
branch
3 times, most recently
from
0454fb7
to
f5af0b4
Compare
fsmanuel
force-pushed
the
update-ember-cli-to-4-x
branch
2 times, most recently
from
7185f01
to
b752e9a
Compare
fsmanuel
force-pushed
the
update-ember-cli-to-4-x
branch
from
c414bbc
to
a3f53f0
Compare
|
Could you add ember 4.4 to ember-try/actions configs? |
knownasilya
reviewed
May 30, 2023
|
@knownasilya We don't need to add 4.4 as it's the default (in package.json) and tested via the normal tests. It seems |
knownasilya
reviewed
May 30, 2023
fsmanuel
force-pushed
the
update-ember-cli-to-4-x
branch
from
c2de606
to
c3859c0
Compare
fsmanuel
changed the title
knownasilya
approved these changes
May 30, 2023
|
@knownasilya Thanks for the review! |
mansona
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-font-awesomewith@fortawesome/ember-fontawesomeThere will be a follow up PR with the update to ember-cli v4.8 as that is more involved and needs changes for ember-data to work.
Release, Beta, and Canary are expected to fail. Current test coverage is
3.28->4.4#716