Add unique group_label to build variables in getEBCNode function #6487
Conversation
buildenv/jenkins/openjdk_tests
Outdated
| string(name: 'platform', value: params.PLATFORM), | ||
| string(name: 'nodeType', value: 'testmachine'), | ||
| string(name: 'TIME_LIMIT', value: expectedNodeLifespan.toString()), | ||
| string(name: 'group_label', value: UID.randomUUID().toString()), |
There was a problem hiding this comment.
I think it is misleading to set UUID as group_label. Instead group_label, call it JOB_UUID as the parameter name. At the end of the day, this is a dummy parameter.
btw, in EBC_Create_Node job, the parameters are mixed with upper case, camel case, and lower case. We should use one naming format.
There was a problem hiding this comment.
Actually the function of that parameter is label in reality but we pass a random UUID here which can be replaced by any meaningful string instead. The EBC Create Node set that string on machine as label and with that test pipeline access created nodes. So it is not just a workaround as dummy param but instead by deciding the label inside the AQA pipeline we avoid that mentioned issue.
For the param names, you are absolutely right. I will unify it.
This avoid issue with merging similar run of create node pipeline into one and not creating a node per each test list Signed-off-by: mahdi@ibm.com
mahdipub
force-pushed
the
EBC_pipeline_call_fix
branch
from
ac7fde0 to
ffcbda8
Compare
4 participants
This avoid issue with merging similar run of create node pipeline into one and not creating a node per each test list
Signed-off-by: mahdi@ibm.com